Handle interrupted messages gracefully #423
Labels
Comments
facundominguez
referenced
this issue
in haskell-distributed/network-transport-tcp
May 14, 2019
Instead of using schedule/runScheduled actions separately, because they are exceptions unsafe, we introduce a `withScheduledAction` function that cares about the safety by providing correct finalizers. X-Bug-URL: https://cloud-haskell.atlassian.net/browse/DP-109
|
The problem is that the receiver has no idea whether msg is Ok or not. It just reads the specified number of bytes received from the 1st msg chunk (see recvWithLength). So I think the right solution would be at the sender side to send the whole msg and avoid being interrupted on sendMany by some outer non-IOException (like ProcessLinkException which happens quite often on our setup). This can be done by calling sendMany in a separate green-thread. The OS buffers become available quite fast, usually. And even if the parent thread will die in a meanwhile because of an exception - it should not take long for the child to finish. See the proposed patch at haskell-distributed/network-transport-tcp#86. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seem interrupting send calls of the TCP transport can sometimes produce the receiver side to append incomplete messages with unrelated messages and deliver that to upper layers.
Either interrupted messages should become impossible, or the receiver should be stopped from delivering these messages upwards.
See the discussion in haskell-distributed/network-transport-tcp@9ec9c1a#r33404578
cc @andriytk
The text was updated successfully, but these errors were encountered: