Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default version "latest" #58

Closed
tfausak opened this issue Apr 21, 2024 · 1 comment · Fixed by #60
Closed

Make default version "latest" #58

tfausak opened this issue Apr 21, 2024 · 1 comment · Fixed by #60

Comments

@tfausak
Copy link
Contributor

tfausak commented Apr 21, 2024

Instead of hard coding a default version that needs to be updated sometimes (#57), I think the default version should be "latest". That way users will get the latest version of HLint without anyone needing to change anything. And if users want to pin the current latest version at time of writing, they can specify the version input just like before.

I'd be happy to open a PR adding this functionality if it's desired. You can see how I do this with my cabal-gild-setup-action here: https://github.com/tfausak/cabal-gild-setup-action/blob/5aa7281b9e1d33818ed53230eef6f73dda3f89e1/index.js#L37

@mihaimaruseac
Copy link
Collaborator

That's a good idea. I haven't tested it before, but I think sensible defaults instead of hardcoded values are better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants