-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable json logging format #177
Comments
Thanks for raising! I'd like to add this. The equivalent Vault server log option are here for reference/consistency: https://www.vaultproject.io/docs/commands/server#log-format. Although we already diverged by using -debug instead of -log-level. The logging library supports JSON output already, so it should be relatively straightforward if you're interested in tackling it: https://pkg.go.dev/github.com/hashicorp/go-hclog#LoggerOptions. Otherwise I'll get to this at some point. |
Thanks @tomhjp for the details, I'll see if I can set aside a little time to tackle and PR it. |
Is this request still open? It would be great if this capability is added to the csi. |
@tomhjp Let me know if there are any issues with the MR. |
Any update? |
Specifically for GKE environments that leverage Google Cloud Operations Logging, logs generated by the provider are all classified as ERROR rather than the proper type as outlined in stdout/stderr. It would be helpful to be able to set the log output in json format such that Operations Logging can properly classify the log type.
The text was updated successfully, but these errors were encountered: