Support POST to get secret for Kubernetes. #367
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 0 out of 2 committers have signed the CLA.
Have you signed the CLA already but the status is still pending? Recheck it. |
|
Hi @j4nos - thanks for this contribution! Please don't forget to sign the CLA. If you work for a company that has a corporate CLA in place, make sure the "organization" for your GitHub profile is publicly viewable. Thanks! :) |
There was a problem hiding this comment.
Hey @j4nos thanks for this contribution. I think there is a small naming oversight and the code does not work as intended at the moment. Would it be possible to write a test or paste some outputs in the description to confirm you were able to successfully test this modification before updating the pull request?
We also highly encourage contributors to:
- Create an issue (even if retroactively) associated with the PR describing the problem and how their solution solves it for traceability
- Add a small example or explanation in the README to help people understand how to use the feature
- Add a brief description of the enhancement in the
Unreleasedsection of the CHANGELOG.md to document changes for future releases
Thank you!
| @@ -35,7 +35,12 @@ async function getSecrets(secretRequests, client) { | |||
| cachedResponse = true; | |||
| } else { | |||
| try { | |||
| const result = await client.get(requestPath); | |||
| let result; | |||
| if (bodyReq) { | |||
There was a problem hiding this comment.
The variable is currently unresolved, did you mean to name the new body argument passed to getSecrets bodyReq instead?
| @@ -39,6 +39,9 @@ inputs: | |||
| authPayload: | |||
| description: 'The JSON payload to be sent to Vault when using a custom authentication method.' | |||
| required: false | |||
| postPayload: | |||
| description: 'The JSON payload to be sent to Vault over a POST request, enabled POST instead of GET.' | |||
| required: false | |||
There was a problem hiding this comment.
I think we should document this new input in the README alongside the ones already documented there.
maxcoulombe
added
the
waiting-for-response
|
Hey, I'll close this PR due to inactivity but if you still would like this improvement to make it in and find some time to adress the review comments feel free to re-open it and ping me! |
No description provided.