fix: allow downloading S3 files from MinIO over http (#570)

vsarunas · web-flow · commit 228ad65a8b51 · 2025-12-17T15:07:13.000+05:30
* fix: allow downloading S3 files from MinIO over http
* validate scheme, enforce https by default
diff --git a/get_s3.go b/get_s3.go
@@ -372,7 +372,11 @@ func (g *S3Getter) newS3Client(
 		opts.UsePathStyle = true
 		// If it's not an AWS domain, set the custom endpoint
 		if !isAWSDomain {
-			opts.BaseEndpoint = aws.String("https://" + url.Host)
+			scheme := url.Scheme
+			if scheme == "" {
+				scheme = "https"
+			}
+			opts.BaseEndpoint = aws.String(scheme + "://" + url.Host)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,11 @@ func (g *S3Getter) newS3Client(`
`372`	`372`	`opts.UsePathStyle = true`
`373`	`373`	`// If it's not an AWS domain, set the custom endpoint`
`374`	`374`	`if !isAWSDomain {`
`375`		`- opts.BaseEndpoint = aws.String("https://" + url.Host)`
	`375`	`+ scheme := url.Scheme`
	`376`	`+ if scheme == "" {`
	`377`	`+ scheme = "https"`
	`378`	`+ }`
	`379`	`+ opts.BaseEndpoint = aws.String(scheme + "://" + url.Host)`
`376`	`380`	`}`
`377`	`381`	`}`
`378`	`382`