Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown parser should support embedding and restrictions on content #275

Open
jace opened this issue Jul 20, 2020 · 2 comments
Open

Markdown parser should support embedding and restrictions on content #275

jace opened this issue Jul 20, 2020 · 2 comments

Comments

@jace
Copy link
Member

jace commented Jul 20, 2020

  1. Allowing externally hosted images creates an information leak wherein the external host receives traffic from users, revealing their IP, browser info and referrer. Some use cases may also require disallowing embedded images entirely.

  2. Naked URLs on a paragraph by themselves should be converted into embeds where applicable (images, videos, tweets, etc)

Both require (a) additional flags to the Markdown parser, and (b) callbacks for custom processing, or custom extensions passed in.

@jace
Copy link
Member Author

jace commented Jul 20, 2020

The MarkdownComposite type also needs to support these additional flags (a) in the column configuration and (b) in the instance method for one-off customization (for example, the Comment.message column in Funnel may change restrictions depending on the user's role).

@jace
Copy link
Member Author

jace commented Jul 20, 2020

#184 is also for the MarkdownComposite customization requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant