PR Conversation and PR changes: remaining fixes

[foalsboy]

This is the list of remaining fixes for PR Conversation and PR changes pages.

⏳ – PP will be able to complete this by 3.02-4.02
⚠️ – It needs some PIPE attention since we're not able to test/fix it ourselves, cc @abhinavrastogi-harness
❌ – PP need more time to do quality code refactoring, so we will work on it after 4.02

PR Conversation

• ⏳ Need to review the buttons—our divider is slightly larger.

Images

• ⚠️ PIPE ⚠️ In this state, there should be a text indicating who resolved the comment. (Since I’m the only reviewer in my PR, I’m not sure if this will appear.)

Images

• ⏳ Colors:

  • Icon: icon-08

  • Background: bg-02
    - Circle border: border-04 + radial gradient

  • Message connection: gradient in design

Images

• ❌ Spacing adjustments:
  • Red: 16px
  • Yellow: 6px

Images

• ❌ The spacing in this state still looks too large.

Images

• ❌ Padding is correct (28px), but the container height seems unnecessarily tall.

Images

PR Changes

• ❌ When adding a comment in Changes, there are now no separators between the code and the comment.

Images

• ⏳ As far as I understand, these elements haven’t been adjusted yet, but we need to double-check with the design—currently, they are quite off in terms of spacing, sizes, icons, colors, and positioning.

Images

• ⏳ This section hasn’t been updated either, but we should look into it. (Design reference here.)

Images

• ❌ Spacing adjustments:

  • Should be 12px, but it’s currently set to 8px.

Images

• Some areas have excessive spacing, should be 8px.

Images

• ⚠️PIPE ⚠️ Button is not clickable—needs fixing. Also the padding between the text to the left border of the button should be a bit bigger.

Images