Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a means for the application to configure battery voltage for DeviceStatusAns #74

Open
janakj opened this issue Jun 5, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@janakj
Copy link
Collaborator

janakj commented Jun 5, 2022

This module contains the code to measure batter and temperature levels. The measured battery voltage currently doesn't appear to be integrated into LoRaWAN. Check if this code works correctly and maybe integrate it into the device reporting MAC command.

@janakj janakj self-assigned this Jun 5, 2022
@janakj janakj added the enhancement New feature or request label Jun 5, 2022
@janakj janakj added this to the Release 1.5.0 milestone Jun 5, 2022
@janakj
Copy link
Collaborator Author

janakj commented Jun 8, 2022

Instead of integrating the code that measures battery voltage with an ADC, it might be more flexible to implement a new AT command AT$BAT=value and let the application set the battery level via this AT command. This approach will allow the application to apply custom battery voltage measuring techniques and to perform platform-specific conversions. Suggested by @hubmartin.

In addition to that, it might also make sense to implement a new event notification command that would be emitted by the modem once the transmitter has been activated. The application could then use the notification to properly time battery voltage measurements during LoRa transmissions. It should be possible to turn the event notification on or off from the application.

@janakj janakj changed the title Double-check adc.[ch] Provide a means for the application to configure battery voltage for DeviceStatusAns Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant