Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setKey documentation and occurrences not up to date #247

Open
Hovestar opened this issue Jun 11, 2021 · 0 comments
Open

setKey documentation and occurrences not up to date #247

Hovestar opened this issue Jun 11, 2021 · 0 comments

Comments

@Hovestar
Copy link

In the documentation for setKey (https://harbour.github.io/doc/harbour.html#setkey) it mentions a 3rd param that is a condition on when to return the codeblock. If the condition is false SetKey() returns false rather than nil and the documentation doesn't reflect this. This then leads to a few bugs in the source:
An example of it being done well is E:\harbour\contrib\gtwvg\class.prg:553 which checks isblock.

Bugs:
In src\rtl\achoice.prg:129 there's this CASE ( bAction := SetKey( nKey ) ) != NIL.
In contrib\gtwvw\tests\demo.prg:1029
There may be some things related to FUNCTION CSetKey in contrib\hbct\ctmisc.prg
In contrib\hbct\getsecrt.prg:127
In contrib\hbmisc\hbedit.prg:288 Which does it right on line 360
In contrib\hbnf\menuto.prg:239
In contrib\hbnf\popadder.prg:1301
In contrib\hbnf\sinkey.prg:42
In contrib\hbnf\sinkey.prg:117
In src\rtl\browse.prg:134
In src\rtl\dbedit.prg:224
In src\rtl\dbedit.prg:136
In src\rtl\menuto.prg:188
In src\rtl\menuto.prg:478
In src\rtl\tgetlist.prg lines 323, 938, and 1232
In src\rtl\tmenusys.prg:187
In src\rtl\wait.prg:62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant