Don't destroy() after end()

kanongil · Marsup · commit 591258aacd1e · 2024-03-13T15:31:49.000+01:00
diff --git a/lib/core.js b/lib/core.js
@@ -569,8 +569,9 @@ exports = module.exports = internals.Core = class {
                             if (socket.readable) {
                                 socket.end(internals.badRequestResponse);
                             }
-
-                            socket.destroy(err);
+                            else {
+                                socket.destroy(err);
+                            }
                         });
                         return;
                     }
@@ -581,7 +582,6 @@ exports = module.exports = internals.Core = class {
                 }
                 else {
                     socket.end(internals.badRequestResponse);
-                    socket.destroy(err);
                 }
             }
             else {

Original file line number	Diff line number	Diff line change
`@@ -569,8 +569,9 @@ exports = module.exports = internals.Core = class {`
`569`	`569`	`if (socket.readable) {`
`570`	`570`	`socket.end(internals.badRequestResponse);`
`571`	`571`	`}`
`572`		`-`
`573`		`- socket.destroy(err);`
	`572`	`+ else {`
	`573`	`+ socket.destroy(err);`
	`574`	`+ }`
`574`	`575`	`});`
`575`	`576`	`return;`
`576`	`577`	`}`
`@@ -581,7 +582,6 @@ exports = module.exports = internals.Core = class {`
`581`	`582`	`}`
`582`	`583`	`else {`
`583`	`584`	`socket.end(internals.badRequestResponse);`
`584`		`- socket.destroy(err);`
`585`	`585`	`}`
`586`	`586`	`}`
`587`	`587`	`else {`