Use slices.Clone for copying slices

Author: hansmi

group.go

@@ -1,6 +1,10 @@
 package main
 
-import "github.com/hansmi/prometheus-lvm-exporter/lvmreport"
+import (
+	"slices"
+
+	"github.com/hansmi/prometheus-lvm-exporter/lvmreport"
+)
 
 type group struct {
 	name lvmreport.GroupName
@@ -13,7 +17,7 @@ type group struct {
 }
 
 func (r *group) allDescriptors() []*descriptor {
-	d := append([]*descriptor(nil), r.keyFields...)
+	d := slices.Clone(r.keyFields)
 	d = append(d, r.infoFields...)
 	d = append(d, r.metricFields...)
 	return d

group_test.go

@@ -82,7 +82,7 @@ func checkSingleDescriptor(t *testing.T, g *group, d *descriptor) {
 func checkReportFields(t *testing.T, g *group, fields []*descriptor) {
 	t.Helper()
 
-	sortedFields := append([]*descriptor(nil), fields...)
+	sortedFields := slices.Clone(fields)
 
 	slices.SortFunc(sortedFields, func(a, b *descriptor) int {
 		return strings.Compare(a.fieldName, b.fieldName)

groupcollector.go

@@ -59,7 +59,7 @@ func newGroupCollector(g *group) *groupCollector {
 		keyLabelNames = append(keyLabelNames, d.metricName)
 	}
 
-	infoLabelNames := append([]string(nil), keyLabelNames...)
+	infoLabelNames := slices.Clone(keyLabelNames)
 
 	for _, d := range g.infoFields {
 		c.infoFields = append(c.infoFields, d.fieldName)
@@ -103,7 +103,7 @@ func (c *groupCollector) collect(ch chan<- prometheus.Metric, data *lvmreport.Re
 			keyValues = append(keyValues, row[name])
 		}
 
-		infoValues := append([]string(nil), keyValues...)
+		infoValues := slices.Clone(keyValues)
 
 		for _, name := range c.infoFields {
 			infoValues = append(infoValues, row[name])

lvmreport/command.go

@@ -6,6 +6,7 @@ import (
 	"log"
 	"os"
 	"os/exec"
+	"slices"
 	"strings"
 
 	"github.com/kballard/go-shellquote"
@@ -32,7 +33,7 @@ func NewCommand(args []string) *Command {
 }
 
 func (c *Command) completeArgs() []string {
-	args := append([]string(nil), c.args...)
+	args := slices.Clone(c.args)
 
 	args = append(args,
 		"fullreport",