Populate SHA-256 checksum only on success

hansmi · hansmi · commit f64d26f83cfe · 2022-11-21T23:57:28.000+01:00
diff --git a/internal/snapshotstream/stream.go b/internal/snapshotstream/stream.go
@@ -133,11 +133,12 @@ func (s *Stream) WriteTo(w io.Writer) error {
 	err := s.writeTo(io.MultiWriter(w, digestw))
 
 	sf := api.DownloadStatusFinished{
-		Success:   (err == nil),
-		Sha256Hex: hex.EncodeToString(digestw.Sum(nil)),
+		Success: (err == nil),
 	}
 
-	if err != nil {
+	if err == nil {
+		sf.Sha256Hex = hex.EncodeToString(digestw.Sum(nil))
+	} else {
 		msg := err.Error()
 		sf.ErrorText = &msg
 	}

Original file line number	Diff line number	Diff line change
`@@ -133,11 +133,12 @@ func (s *Stream) WriteTo(w io.Writer) error {`
`133`	`133`	`err := s.writeTo(io.MultiWriter(w, digestw))`
`134`	`134`
`135`	`135`	`sf := api.DownloadStatusFinished{`
`136`		`- Success: (err == nil),`
`137`		`- Sha256Hex: hex.EncodeToString(digestw.Sum(nil)),`
	`136`	`+ Success: (err == nil),`
`138`	`137`	`}`
`139`	`138`
`140`		`- if err != nil {`
	`139`	`+ if err == nil {`
	`140`	`+ sf.Sha256Hex = hex.EncodeToString(digestw.Sum(nil))`
	`141`	`+ } else {`
`141`	`142`	`msg := err.Error()`
`142`	`143`	`sf.ErrorText = &msg`
`143`	`144`	`}`