Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - [md-menu] nextOnAnchorClick not working with closeOnOutsideClick #155

Open
2 of 9 tasks
EliotRagueneau opened this issue Oct 13, 2023 · 1 comment
Open
2 of 9 tasks
Labels
bug Something isn't working P3

Comments

@EliotRagueneau
Copy link
Contributor

EliotRagueneau commented Oct 13, 2023

Which ngx-ui-tour-* package is the source of the bug?

md-menu

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/angular-wau2z8?file=src%2Fapp%2Fui-tour-demo.component.ts

Description

When a step is having both nextOnAnchorClick and closeOnOutsideClick, clicking on the anchor is closing the tour instead of going to the next step.

I found a way to fix this issue from the user side, which also enhance a bit the backdrop, by adding a div color-backdrop when the tour is present, with the following scss:

.color-backdrop {
  position: fixed;
  top: 0;
  bottom: 0;
  left: 0;
  right: 0;
  pointer-events: auto;
  background: rgba(black, 0.5);
  opacity: 1 !important;
  z-index: 998;
}

And having the following scss on active anchor, though it requires to add clickable on the anchors having closeOnOutsideClick

.touranchor--is-active {
  position: relative;
  z-index: 999;
  &[clickable] {
    z-index: 1003;
  }
}

Maybe you could to try to include that fix natively, or maybe another solution which could potentially work on all situations, since mine is quite specific to Material Design😄

Angular version

16.2.6

Ngx UI Tour version

11.0.4

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@EliotRagueneau EliotRagueneau added bug Something isn't working needs-triage labels Oct 13, 2023
@hakimio hakimio changed the title 🐞 - nextOnAnchorClick not working with closeOnOutsideClick 🐞 - [md-menu] nextOnAnchorClick not working with closeOnOutsideClick Oct 16, 2023
@hakimio hakimio added P3 and removed needs-triage labels Oct 16, 2023
@hakimio
Copy link
Owner

hakimio commented Oct 16, 2023

I don't have any better solutions, but, if you can figure out a simple way to fix this from the library side, feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
None yet
Development

No branches or pull requests

2 participants