Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Proposal]: Generalized Additive Models #417

Open
osheari1 opened this issue Apr 9, 2019 · 7 comments
Open

[Feature Proposal]: Generalized Additive Models #417

osheari1 opened this issue Apr 9, 2019 · 7 comments

Comments

@osheari1
Copy link

osheari1 commented Apr 9, 2019

I'm working on a project that requires GAMs. I'm more than willing to implement this myself, as long as it fits in with the Smile road map.

One other caveat is, I would only be able to implement it in Scala (rather than Java). Would this be an issue?

@haifengl
Copy link
Owner

Scala is fine. Please implements it in the scala module and corresponding package, e.g. smile.regression.

@osheari1
Copy link
Author

👍

@osheari1
Copy link
Author

Would it be OK to add an additional dependency for vectorization vs iterating over double arrays? If not I can just deal with the looping.

@haifengl
Copy link
Owner

You would like to add a library dependency for vector processing? In general, we hide this details in math module (mostly in Matrix interface). With different plugin, we can have pure java implementation or native one.

@ValdarT
Copy link

ValdarT commented Aug 3, 2019

Hi. Any updates on this?

@osheari1
Copy link
Author

osheari1 commented Aug 5, 2019

Hey,

Unfortunately I haven't had any time to work on this in the past couple months due to moving / new job ect. After starting the project, it turned out it would've required way more work than I initially expected for 1 person. If we could get more people to contribute, finishing it would become a lot more viable.

@ValdarT
Copy link

ValdarT commented Sep 5, 2019

Why close the issue? GAMs seem like a great addition so the feature request makes sense (whether there is ongoing work on it or not)?

@haifengl haifengl reopened this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants