Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor schedulers #11

Open
hafriedlander opened this issue Oct 16, 2022 · 0 comments
Open

Refactor schedulers #11

hafriedlander opened this issue Oct 16, 2022 · 0 comments

Comments

@hafriedlander
Copy link
Owner

Hlky did a great job the k-diffuser schedulers, and we now have them running comparibly to Compvis, but they need another pass to be great.

  • They all share a lot of common code, so that should be factored into a common base class
  • They all need converting to 0.4.1-style "All PyTorch all the time" schedulers
  • We need more tests to make sure we're behaving the same as Compvis (although this seems like a common problem, as I often see differences even between DDIM or K_LMS in Diffusers versus Compvis, and FP16 + XFormers only makes it worse).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hafriedlander