Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting to pull requests #1330

Open
1 of 4 tasks
trillium opened this issue Mar 12, 2023 · 4 comments · May be fixed by #1823
Open
1 of 4 tasks

Add linting to pull requests #1330

trillium opened this issue Mar 12, 2023 · 4 comments · May be fixed by #1823
Assignees
@bkmorgan3
Labels
complexity: medium feature: Infrastructure Secrets, Prod and Dev setup, etc. role: devops size: 2pt Can be done in 7-12 hours
Milestone
04.01 Existing Fe...

Comments

@trillium
Copy link
Member

trillium commented Mar 12, 2023 •
edited
Loading

Overview

Devs on this team have differing eslint configurations. VRMS should standardize linting so that only relevant changes show up in commits, standardizing things like:
import {foo} from './foo' vs
import { foo } from './foo'

Action Items

  • Research a linting system
    • Use ESLint and Prettier
  • Add that linting system to VRMS
  • Test to see if new system is working

Resources/Instructions
@juliagab56 juliagab56 added this to the 3.01 Existing Features milestone Jul 5, 2023
@jbubar jbubar added size: 2pt Can be done in 7-12 hours and removed x-size: 3pt labels Jul 13, 2023
@JackHaeg JackHaeg moved this to New Issue Approval in P: VRMS: Project Board Jun 13, 2024
@angela-lee1 angela-lee1 self-assigned this Jun 20, 2024
@angela-lee1 angela-lee1 removed their assignment Jul 29, 2024
@trillium trillium added the Close after Vite merge Issue that is no longer relevant after Vite merge and can be closed label Aug 15, 2024
@trillium trillium moved this from New Issue Approval to Icebox in P: VRMS: Project Board Aug 15, 2024
@JackHaeg JackHaeg mentioned this issue Aug 27, 2024
Open
@JackHaeg JackHaeg moved this from Icebox to Prioritized Backlog in P: VRMS: Project Board Aug 27, 2024
@JackHaeg
Copy link
Member

@trillium please add additional Action Items to this issue

@JackHaeg
Copy link
Member

@trillium Closing now that Vite has been merged.

@JackHaeg JackHaeg closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@github-project-automation github-project-automation bot moved this from Prioritized Backlog to Final QA (product) in P: VRMS: Project Board Sep 19, 2024
@trillium
Copy link
Member Author

Reopening this issue, close after vite merge was a miss-label and consistent linting still needs to be implemented.

@trillium trillium reopened this Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Final QA (product) to New Issue Approval in P: VRMS: Project Board Sep 24, 2024
@trillium trillium moved this from New Issue Approval to Prioritized Backlog in P: VRMS: Project Board Sep 24, 2024
@trillium trillium added feature: Infrastructure Secrets, Prod and Dev setup, etc. complexity: medium and removed Close after Vite merge Issue that is no longer relevant after Vite merge and can be closed feature: Github Actions labels Oct 15, 2024
@bkmorgan3 bkmorgan3 self-assigned this Dec 23, 2024
@trillium trillium mentioned this issue Jan 6, 2025
Closed
@JackHaeg JackHaeg moved this from Prioritized Backlog to In progress in P: VRMS: Project Board Jan 14, 2025
@bkmorgan3 bkmorgan3 linked a pull request Jan 20, 2025 that will close this issue
Open
@bkmorgan3 bkmorgan3 moved this from In progress to Questions/Review in P: VRMS: Project Board Jan 20, 2025
@JackHaeg
Copy link
Member

JackHaeg commented Feb 5, 2025 •
edited
Loading

Hi @bkmorgan3 I noticed that you moved this issue to the Questions/Review column. When you have a moment, can you share any specific questions / blockers you have related to this issue?

Happy to bring up this issue at our next All Team meeting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkmorgan3 bkmorgan3

Labels
complexity: medium feature: Infrastructure Secrets, Prod and Dev setup, etc. role: devops size: 2pt Can be done in 7-12 hours
Projects
P: VRMS: Project Board
Status: Questions/Review
Milestone
04.01 Existing Features
Development

Successfully merging a pull request may close this issue.

Formatting Setup bkmorgan3/VRMS
Add linting bkmorgan3/VRMS
7 participants
@trillium @bkmorgan3 @angela-lee1 @ExperimentsInHonesty @jbubar @juliagab56 @JackHaeg