Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize DOM modifications #56

Open
eliemichel opened this issue Mar 9, 2015 · 2 comments
Open

Minimize DOM modifications #56

eliemichel opened this issue Mar 9, 2015 · 2 comments
Labels
guideline

Comments

@eliemichel
Copy link
Member

Guidelines are meant to remain open issues, just for contributors information.

Lines like Geolocation.waitPosition(stands) && Stations.waitList(stands) are a little bit violent because they cause stands being called a lot of times. Since this function heavily modifies the DOM (even not to change anything) that should be avoided.

Actually it has my Firefox crash and I will increase the wait_position_timeout right now.
@Phyks
Copy link
Member

Phyks commented Oct 4, 2015

still an issue?

@eliemichel
Copy link
Member Author

Still a guideline. It is meant to remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
guideline
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Phyks @eliemichel