Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot file names could collide #26

Open
mikelietz opened this issue Mar 21, 2013 · 2 comments
Open

screenshot file names could collide #26

mikelietz opened this issue Mar 21, 2013 · 2 comments

Comments

@mikelietz
Copy link
Member

Currently they're just the slugified repository name. It's possible two repositories (a theme and a plugin, or even two differently-guid-ed themes) could share a name, and thus they would have the same screenshot.

@ringmaster
Copy link
Member

I suggest using {$pluggable_slug}-{$version_slug}-{$guid}-{$filename}.{$extension}

This will allow separate images per plugin, per version, and eventually support multiple "screenshots" per addon.

@chrisjdavis
Copy link
Contributor

Yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants