Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Page Title? #195

Open
digilou opened this issue Apr 11, 2018 · 1 comment
Open

Dynamic Page Title? #195

digilou opened this issue Apr 11, 2018 · 1 comment
Labels
accessibility question Further information is requested

Comments

@digilou
Copy link
Collaborator

digilou commented Apr 11, 2018

Going through Scott Vinkle's article Creating Accessible React Apps, and wondering should we create a dynamic title @gwg-women/all-gwg-women? Say, when someone searches "pizza", the title would reflect "Pizza | Mappa" as the title within the browser tab. Maybe I'm overthinking this very basic SPA...?

If anything, I'm sure several of you would be interested in reading this article yourself! I'm still new to React, but I wanted to see what Scott wrote, as he's given many talks about this making React apps accessible.
@digilou digilou added question Further information is requested accessibility labels Apr 11, 2018
@khusbuchandra
Copy link
Collaborator

I really like how it improves the accessibility part, that's a good idea. Thanks @digilou for suggesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digilou @khusbuchandra