Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop manifest.json for project #122

Open
tanyagupta opened this issue Mar 29, 2018 · 10 comments
Open

Develop manifest.json for project #122

tanyagupta opened this issue Mar 29, 2018 · 10 comments
Labels
good first issue Good for newcomers

Comments

@tanyagupta
Copy link
Collaborator

https://developers.google.com/web/fundamentals/web-app-manifest/

The web app manifest is a simple JSON file that gives you, the developer, the ability to control how your app appears to the user in areas where they would expect to see apps (for example, a mobile device's home screen), direct what the user can launch, and define its appearance at launch.

Web app manifests provide the ability to save a site bookmark to a device's home screen. When a site is launched this way:

It has a unique icon and name so that users can distinguish it from other sites.
It displays something to the user while resources are downloaded or restored from cache.
It provides default display characterstics to the browser to avoid too abrupt transition when site resources become available.
It does all this through the simple mechanism of metadata in a text file. That's the web app manifest.

@tanyagupta tanyagupta added the good first issue Good for newcomers label Mar 29, 2018
@amr08
Copy link
Collaborator

amr08 commented Mar 29, 2018

Just a quick note, a basic version of manifest.json is automatically created after npm run build in create-react-app. It will get rebuilt everytime so if someone adds to it, we would want to protect/copy that file somewhere else!

@tanyagupta
Copy link
Collaborator Author

True @amr08 Thanks for pointing that out. What do you think ?

Tagging some folks for views on whether we should leave it as a basic one or add more functionality @khusbuchandra @sonalikatara @agonzalez0515 @digilou @PepperAddict

@agonzalez0515
Copy link
Collaborator

I think the one CRA creates should be ok for now. I'm wondering, should I be using that to cache the assets? Or adding it to the cache along with the assets?

@digilou
Copy link
Collaborator

digilou commented Mar 30, 2018

@tanyagupta I'm curious about this. It sounds like a manifest is good to qualify this is a progressive web app (PWA) that people can then install on their home screen: https://developers.google.com/web/fundamentals/web-app-manifest/
This is a PWA issue that I see mentioned when running a full audit with Lighthouse.

But if @amr08 is saying it gets rebuilt, maybe we need to lock one to reap the benefits of a manifest that Google suggests?

@tanyagupta
Copy link
Collaborator Author

tanyagupta commented Mar 30, 2018 via email

@khusbuchandra
Copy link
Collaborator

Where are we with this? Any plans on someone starting on it?

@sonalikatara
Copy link
Collaborator

While I was working on favicon I came across some interesting reads one of them is https://medium.com/front-end-hacking/react-by-example-part-4-5d32168db362
manifest.json needs to be put in public folder. I can put one in if you agree. @amr08 what is your take on this, does this make sense ?
@tanyagupta @agonzalez0515 @khusbuchandra @digilou

@digilou
Copy link
Collaborator

digilou commented Apr 11, 2018

WOW @sonalikatara this is perfect timing for me, as I'm working on a MERN app right now, and all of this architecture has been confusing. It looks like our structure is right on par with what John is saying, so manifest.json in the public folder sounds fine to me.

@agonzalez0515
Copy link
Collaborator

Sounds good to me. I’m wondering, if we put it in the public/ folder in development, does the build command keep it there in production? Need to look into CRA build?

@sonalikatara
Copy link
Collaborator

@agonzalez0515 , this is what Jhon say's about the build process and manifest.json
During the build process

The files favicon.ico and manifest.json were copied over from the public folder we discussed earlier.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants