Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflowing player-title for very long album names #4

Open
THeK3nger opened this issue Jun 20, 2023 · 5 comments
Open

Overflowing player-title for very long album names #4

THeK3nger opened this issue Jun 20, 2023 · 5 comments

Comments

@THeK3nger
Copy link
Contributor

The King Gizzard & The Wizard Lizard broke so many players with their long-ass album title :D On inter.tube, I've found this bad overflow.

CleanShot 2023-06-20 at 19 30 39@2x

Playing with the devtools of the browser, I saw that adding margin-left: 100px (more or less) to .player-title solves the problem.

(I can try to make a PR for this later, if it is okay for you.)

@guregu
Copy link
Owner

guregu commented Jun 20, 2023

Oh man that is quite the song title. Thank you, PR would be appreciated! I will credit you :-)

@guregu
Copy link
Owner

guregu commented Jun 25, 2023

I tried testing the fix but I can still break it with certain resolutions. I think we need to tweak it to use flexbox or something to hold the album art to a fixed size (e.g. 20vw) so we can offset the title by the same amount. I'll take another look once I get local dev mode finished.

@THeK3nger
Copy link
Contributor Author

Yes! Definitely, a flexbox is the right approach. I also started experimenting with it, but without a local dev mode, I was not confident in the stability of what I did. :)

@guregu
Copy link
Owner

guregu commented Jun 26, 2023

I just merged some stuff that makes it a lot easier to run locally, and also updated the readme. See if you can get it running!

@THeK3nger
Copy link
Contributor Author

Great! I am running it locally without any problem. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants