-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflowing player-title for very long album names #4
Comments
Oh man that is quite the song title. Thank you, PR would be appreciated! I will credit you :-) |
I tried testing the fix but I can still break it with certain resolutions. I think we need to tweak it to use flexbox or something to hold the album art to a fixed size (e.g. 20vw) so we can offset the title by the same amount. I'll take another look once I get local dev mode finished. |
Yes! Definitely, a flexbox is the right approach. I also started experimenting with it, but without a local dev mode, I was not confident in the stability of what I did. :) |
I just merged some stuff that makes it a lot easier to run locally, and also updated the readme. See if you can get it running! |
Great! I am running it locally without any problem. :D |
The King Gizzard & The Wizard Lizard broke so many players with their long-ass album title :D On inter.tube, I've found this bad overflow.
Playing with the devtools of the browser, I saw that adding
margin-left: 100px
(more or less) to.player-title
solves the problem.(I can try to make a PR for this later, if it is okay for you.)
The text was updated successfully, but these errors were encountered: