Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal support #519

Open
Jrubzjeknf opened this issue Dec 12, 2024 · 1 comment
Open

Signal support #519

Jrubzjeknf opened this issue Dec 12, 2024 · 1 comment

Comments

@Jrubzjeknf
Copy link

Greetings,

I see that this library is currently not supporting signals. The inputs seem to work, at least on a basic level, but the outputs currently don't work on signals. The IoService seems to expect an output to support a pipe function.

Do you plan to add signal support? It would be nice since Angular has started recommending signals and added a migration to transform @Input() to input().

With kind regards, Jrubzjeknf

@gund
Copy link
Owner

gund commented Dec 14, 2024

Hey, does it matter if the library declares inputs/outputs using classic or signals API?

For you as a user nothing should fundamentally change, you can set inputs or listen to outputs using signals or not via template as before.
It's just internal implementation detail that this lib is not using signals API in the end.
Unless you are using this lib imperatively - then you would have to use signals/rxjs interop API from angular, but the purpose of the lib is to use it's declarative APIs via templates, in which case it should not matter to you anyway.

For now I'm not planning to switch to signals as it will not bring any value for this lib so I prefer to keep it simple using classic APIs.
Also switching to signals would immediately kill backwards compatibility with older versions of Angular, which I still maintain and do not want to break for no reason, until Angular themselves will break this compatibility of course, but for now they've done amazing job keeping forward compatibility with older compiled libs, so I do not even have to rebuild it with the latest Angular compiler!

So what are your reasons for switching this lib to signals API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants