Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infection_monkey.exploit.tools.utils methods to TargetHost.PortScanDataDict #5

Open
2 tasks done
ilija-lazoroski opened this issue Mar 5, 2024 · 2 comments
Open
2 tasks done

Comments

@ilija-lazoroski
Copy link
Collaborator

ilija-lazoroski commented Mar 5, 2024

There is some methods in Monkey repository which we wanted to move to a different repository named plugintoolbox which probably will be open by the time we get to this issue. We didn't know if these methods are going to be stable enough to move them then in TargetHost.PortScanDataDict but now we know.

The methods are located here.

Tasks

  • Make these methods part of TargetHost.PortScanDataDict
    • Unit tests
@mssalvatore
Copy link
Collaborator

Note that these methods can be generalized by passing things like NetworkProtocol and NetworkService as parameters. This is preferable to adding them as-is to PortScanDataDict.

@mssalvatore
Copy link
Collaborator

Resolved by #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants