Upgrade Yarn to v4, take 2 #9662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -7 B (0%) Total Size: 732 kB ℹ️ View Unchanged
|
sndrs
force-pushed
the
sndrs/yarn-4
branch
3 times, most recently
from
3ae7bdf
to
e02ec8e
Compare
cemms1
approved these changes
Dec 6, 2023
Comment on lines
+190
to
+191
| {/* eslint-disable jsx-a11y/label-has-associated-control -- | ||
| i don't know why it's failing, it has htmlFor */} |
There was a problem hiding this comment.
Might have been gremlins - this doesn't fail for me when I checked out your branch and removed these
There was a problem hiding this comment.
ooooh nice, let me look at that
There was a problem hiding this comment.
i still see lint errors if i run yarn lint in apps-rendering without those?
This reverts commit 8661a2c.
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
This is a second attempt at #9466, which hopefully #9791 will make easier
What does this change?
Why?
closes #9421
Screenshot
Note
This is conclusion of a multi-quarter joint-effort with @joecowton1.