-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Revenue message on AU front #12896
Draft
charleycampbell
wants to merge
6
commits into
main
Choose a base branch
from
cc/reader-rev-msg-front
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic that the US Eoy 2024 used, but the ticker colours and copy are different
This needs signed off by the AU team |
Size Change: +10.7 kB (+1.14%) Total Size: 957 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Like we did for the US end of year campaign, we are adding a new component in for the AU campaign. Similarly to the previous implementation for the US, this renders in the Fronts container so we will need to create a new container in the fronts tool with the name '
AU end-of-year 2024
' so it renders.Why?
Explanation from Tom (from this PR)
In the past we've used "Thrashers" to deploy this type of message to the fronts. However, thrashers are not suitable for rich/interactive components like this. This component needs to render a ticker (based on a fetch) and interactive choice cards.
It's now much easier to build this type of thing in DCR as islands, where the relevant source components etc exist. It's also easier to line it up with the columns of the fronts.
Screenshots