Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support darkmode - Comments #9574

Closed
Tracked by #9882
abeddow91 opened this issue Nov 20, 2023 · 4 comments · Fixed by #9885
Closed
Tracked by #9882

Support darkmode - Comments #9574

abeddow91 opened this issue Nov 20, 2023 · 4 comments · Fixed by #9885
Assignees
@sophie-macmillan

Comments

@abeddow91
Copy link
Contributor

No description provided.

@abeddow91 abeddow91 mentioned this issue Nov 20, 2023
Closed
@abeddow91
Copy link
Contributor Author

@HarryFischer to provide designs as this component was previously web only

@abeddow91
Copy link
Contributor Author

Image

@mxdvl mxdvl changed the title Support darkmode - comments Support darkmode - Comments Nov 23, 2023
@mxdvl
Copy link
Contributor

mxdvl commented Nov 23, 2023

Is this resolved by #9634 ?

@sophie-macmillan sophie-macmillan mentioned this issue Nov 27, 2023
Closed
@sophie-macmillan
Copy link
Contributor

sophie-macmillan commented Nov 27, 2023 •
edited
Loading

I've left this open, but moved it into the backlog as we will need to do this work when we support comments
Ticket for supporting comments has been added here: #9667

@JamieB-gu JamieB-gu mentioned this issue Dec 5, 2023
Closed
@sophie-macmillan sophie-macmillan self-assigned this Dec 13, 2023
@sophie-macmillan sophie-macmillan modified the milestone: DCR for Apps Dec 13, 2023
This was referenced Dec 14, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophie-macmillan sophie-macmillan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Darkmode - Comment and CommentReplyPreview guardian/dotcom-rendering
3 participants
@mxdvl @abeddow91 @sophie-macmillan