-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic]: DCR for Apps - Discussion #8745
Labels
Milestone
Comments
Rough tasks that need addressing
|
This was referenced Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
This quarter (Jan-Mar 2024) we’ll be working on implementing discussions in DCAR. We hope will reduce the amount of platform-specific logic in favour of a unified approach. We may also use this as an opportunity to simpliying existing the code and fix bugs.
Key changes required
Discussion in web and Apps differs in that in Apps post endpoints interact with the native layer directly as that's where the user information is know. e.g.
postComment
orreportAbuse
There has been some work to account for this by using callbacks on the
CommentContainer
.When migrating
discussion-rendering
we had opted for expediency to not always follow this pattern, so will need to find those interactions that speak to the discussion API directly and port them over to the paradigm above.We might need to work with Apps here to help create any endpoints that don't exist.
Step 1 - Beta release
DiscussionContainer
are controlled components #10056Step 2 - Beta or PROD release
dispatch
In Discussion #10548useEffectReducer
To Discussion #10549Step 3 - PROD release
Unprioritised / other
isWeb
condition across layouts #10416The text was updated successfully, but these errors were encountered: