Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sharing experience on desktop liveblogs #12411

Closed
domlander opened this issue Sep 19, 2024 · 5 comments · Fixed by #12872
Closed

Improve sharing experience on desktop liveblogs #12411

domlander opened this issue Sep 19, 2024 · 5 comments · Fixed by #12872
Assignees
@DanielCliftonGuardian
Labels
Liveblogs Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…
Milestone
Requests

Comments

@domlander
Copy link
Contributor

domlander commented Sep 19, 2024 •
edited
Loading

The "Share" button on liveblog blocks works really well on mobile phones. However, it is not very useful on desktop (OS and browser dependent), where a user is sometimes unable to simply copy the link. MacOS support has been added for this feature as of version 128 of Chrome, so it is now starting to affect more users and staff.

Image

Suggested improvements from Gabriel, Jonathon & CP:

  • (Design prefer this option) On desktop, use the fallback functionality* to copy the link instead of using the Web Share API
  • On desktop, include a second button "Copy link" next to the share button

Thread: https://groups.google.com/a/guardian.co.uk/g/dotcom.platform/c/8hkcV3k6Flw

*We currently have fallback functionality which will show a Copy Link button instead of a Share button if the Web Share API is not supported. See ShareButton.importable for details.
@domlander domlander self-assigned this Sep 19, 2024
@domlander domlander added this to the Requests milestone Sep 19, 2024
@domlander
Copy link
Contributor Author

Design (Rich & Harry) feedback:

  • Use fallback functionality on desktop screen sizes
  • Do the same for articles, which are also affected

@domlander domlander added Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… and removed Needs Design Input labels Sep 25, 2024
@SiAdcock
Copy link
Contributor

Do the same for articles, which are also affected

Do we need a "copy link" button on articles? The reader would normally copy the URL from the browser's address bar, making this method slightly redundant. What do you think @richcousins @HarryFischer

@domlander
Copy link
Contributor Author

domlander commented Sep 25, 2024 •
edited
Loading

Do we need a "copy link" button on articles? The reader would normally copy the URL from the browser's address bar, making this method slightly redundant. What do you think @richcousins @HarryFischer

The fallback functionality still shows a "Share" button initially, but when it is clicked, the text content changes to "Link copied".

Apologies for the confusion.

@richcousins
Copy link
Collaborator

Do we need a "copy link" button on articles? The reader would normally copy the URL from the browser's address bar, making this method slightly redundant. What do you think @richcousins @HarryFischer

The fallback functionality still shows a "Share" button initially, but when it is clicked, the text content changes to "Link copied".

Apologies for the confusion.

We're happy to drop back all desktop to this functionality – thanks!

@SiAdcock
Copy link
Contributor

The confusion was all mine 😄 Thanks everyone 🙏

@domlander domlander mentioned this issue Oct 3, 2024
Closed
Merged
@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielCliftonGuardian DanielCliftonGuardian

Labels
Liveblogs Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…
Projects
None yet
Milestone
Requests
Development

Successfully merging a pull request may close this issue.

Live blog block desktop sharebutton copy guardian/dotcom-rendering
4 participants
@SiAdcock @domlander @DanielCliftonGuardian @richcousins