From c2ec95d85aa1871baf19d326d31b3b65ed6eac17 Mon Sep 17 00:00:00 2001
From: Rupert Bates <Rupert.Bates@guardian.co.uk>
Date: Mon, 20 Jan 2025 16:29:46 +0000
Subject: [PATCH] Throw an error immediately if urls are missing from config.

---
 .../src/client/userFeatures/membersDataApi.ts  | 18 ++++++++----------
 .../src/client/userFeatures/userBenefitsApi.ts | 16 ++++++++--------
 2 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/dotcom-rendering/src/client/userFeatures/membersDataApi.ts b/dotcom-rendering/src/client/userFeatures/membersDataApi.ts
index c460f26a9f1..9c1447680ae 100644
--- a/dotcom-rendering/src/client/userFeatures/membersDataApi.ts
+++ b/dotcom-rendering/src/client/userFeatures/membersDataApi.ts
@@ -87,16 +87,14 @@ export const syncDataFromMembersDataApi: (
 ) => Promise<UserBenefits> = async (
 	signedInAuthStatus: SignedInWithOkta | SignedInWithCookies,
 ) => {
-	const response = await fetchJson(
-		`${
-			window.guardian.config.page.userAttributesApiUrl ??
-			'/USER_ATTRIBUTE_API_NOT_FOUND'
-		}/me`,
-		{
-			mode: 'cors',
-			...getOptionsHeadersWithOkta(signedInAuthStatus),
-		},
-	);
+	const url = window.guardian.config.page.userAttributesApiUrl;
+	if (!url) {
+		throw new Error('userAttributesApiUrl is not defined');
+	}
+	const response = await fetchJson(url, {
+		mode: 'cors',
+		...getOptionsHeadersWithOkta(signedInAuthStatus),
+	});
 	if (!validateResponse(response)) {
 		throw new Error('invalid response');
 	}
diff --git a/dotcom-rendering/src/client/userFeatures/userBenefitsApi.ts b/dotcom-rendering/src/client/userFeatures/userBenefitsApi.ts
index 0b831bcf5f3..92371811b8e 100644
--- a/dotcom-rendering/src/client/userFeatures/userBenefitsApi.ts
+++ b/dotcom-rendering/src/client/userFeatures/userBenefitsApi.ts
@@ -13,14 +13,14 @@ type UserBenefitsResponse = {
 export const syncDataFromUserBenefitsApi = async (
 	signedInAuthStatus: SignedInWithOkta | SignedInWithCookies,
 ): Promise<UserBenefits> => {
-	const response = await fetchJson(
-		window.guardian.config.page.userBenefitsApiUrl ??
-			'/USER_BENEFIT_API_NOT_FOUND',
-		{
-			mode: 'cors',
-			...getOptionsHeadersWithOkta(signedInAuthStatus),
-		},
-	);
+	const url = window.guardian.config.page.userBenefitsApiUrl;
+	if (!url) {
+		throw new Error('userBenefitsApiUrl is not defined');
+	}
+	const response = await fetchJson(url, {
+		mode: 'cors',
+		...getOptionsHeadersWithOkta(signedInAuthStatus),
+	});
 	if (!validateResponse(response)) {
 		throw new Error('invalid response');
 	}