From 18a0aa934d478becbe4b61c74b7beb1bbfbc7373 Mon Sep 17 00:00:00 2001 From: Marjan Kalanaki Date: Fri, 13 Dec 2024 12:59:07 +0000 Subject: [PATCH] fix lint issues --- dotcom-rendering/src/components/Carousel.importable.tsx | 4 ++-- .../src/components/FetchOnwardsData.importable.tsx | 2 +- dotcom-rendering/src/components/OnwardsUpper.importable.tsx | 2 +- dotcom-rendering/src/layouts/AudioLayout.tsx | 2 +- dotcom-rendering/src/layouts/FrontLayout.tsx | 2 +- dotcom-rendering/src/layouts/NewsletterSignupLayout.tsx | 2 +- dotcom-rendering/src/lib/useIsBridgetCompatible.ts | 2 +- dotcom-rendering/src/lib/useIsHorizontalScrollingSupported.ts | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dotcom-rendering/src/components/Carousel.importable.tsx b/dotcom-rendering/src/components/Carousel.importable.tsx index f125dbc0b16..6aa30b91f38 100644 --- a/dotcom-rendering/src/components/Carousel.importable.tsx +++ b/dotcom-rendering/src/components/Carousel.importable.tsx @@ -9,6 +9,7 @@ import { import libDebounce from 'lodash.debounce'; import { useEffect, useRef, useState } from 'react'; import { ArticleDesign, type ArticleFormat } from '../lib/articleFormat'; +import { getInteractionClient } from '../lib/bridgetApi'; import { formatAttrString } from '../lib/formatAttrString'; import { getSourceImageUrl } from '../lib/getSourceImageUrl_temp_fix'; import { getZIndex } from '../lib/getZIndex'; @@ -24,6 +25,7 @@ import type { import type { LeftColSize } from '../types/layout'; import type { MainMedia } from '../types/mainMedia'; import type { OnwardsSource } from '../types/onwards'; +import type { RenderingTarget } from '../types/renderingTarget'; import type { TrailType } from '../types/trails'; import { Card } from './Card/Card'; import { LI } from './Card/components/LI'; @@ -32,8 +34,6 @@ import { ContainerOverrides } from './ContainerOverrides'; import { FormatBoundary } from './FormatBoundary'; import { Hide } from './Hide'; import { LeftColumn } from './LeftColumn'; -import { getInteractionClient } from '../lib/bridgetApi'; -import { RenderingTarget } from 'src/types/renderingTarget'; type Props = { heading: string; diff --git a/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx b/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx index 2f3d7f9823a..79d8dd751dd 100644 --- a/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx +++ b/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx @@ -6,10 +6,10 @@ import { useApi } from '../lib/useApi'; import { addDiscussionIds } from '../lib/useCommentCount'; import { palette } from '../palette'; import type { OnwardsSource } from '../types/onwards'; +import type { RenderingTarget } from '../types/renderingTarget'; import type { FETrailType, TrailType } from '../types/trails'; import { Carousel } from './Carousel.importable'; import { Placeholder } from './Placeholder'; -import { RenderingTarget } from 'src/types/renderingTarget'; type Props = { url: string; diff --git a/dotcom-rendering/src/components/OnwardsUpper.importable.tsx b/dotcom-rendering/src/components/OnwardsUpper.importable.tsx index 6287f801f33..b41bc8bd2a8 100644 --- a/dotcom-rendering/src/components/OnwardsUpper.importable.tsx +++ b/dotcom-rendering/src/components/OnwardsUpper.importable.tsx @@ -10,11 +10,11 @@ import { useAB } from '../lib/useAB'; import { useIsHorizontalScrollingSupported } from '../lib/useIsHorizontalScrollingSupported'; import { palette } from '../palette'; import type { OnwardsSource } from '../types/onwards'; +import type { RenderingTarget } from '../types/renderingTarget'; import type { TagType } from '../types/tag'; import { BigSixOnwardsContent } from './BigSixOnwardsContent'; import { FetchOnwardsData } from './FetchOnwardsData.importable'; import { Section } from './Section'; -import { RenderingTarget } from 'src/types/renderingTarget'; type PillarForContainer = | 'headlines' diff --git a/dotcom-rendering/src/layouts/AudioLayout.tsx b/dotcom-rendering/src/layouts/AudioLayout.tsx index 3b5bf328fea..498b5e2ddf3 100644 --- a/dotcom-rendering/src/layouts/AudioLayout.tsx +++ b/dotcom-rendering/src/layouts/AudioLayout.tsx @@ -46,8 +46,8 @@ import { parse } from '../lib/slot-machine-flags'; import type { NavType } from '../model/extract-nav'; import { palette as themePalette } from '../palette'; import type { ArticleDeprecated } from '../types/article'; +import type { RenderingTarget } from '../types/renderingTarget'; import { BannerWrapper, Stuck } from './lib/stickiness'; -import { RenderingTarget } from '../types/renderingTarget'; const AudioGrid = ({ children }: { children: React.ReactNode }) => (
{ - hasMinimumBridgetVersion(requiredVersion).then(setIsCompatible); + void hasMinimumBridgetVersion(requiredVersion).then(setIsCompatible); }, [requiredVersion]); return isCompatible; }; diff --git a/dotcom-rendering/src/lib/useIsHorizontalScrollingSupported.ts b/dotcom-rendering/src/lib/useIsHorizontalScrollingSupported.ts index e8ff49d9891..1b9e8980cce 100644 --- a/dotcom-rendering/src/lib/useIsHorizontalScrollingSupported.ts +++ b/dotcom-rendering/src/lib/useIsHorizontalScrollingSupported.ts @@ -26,7 +26,7 @@ export const useIsHorizontalScrollingSupported = (): boolean => { useEffect(() => { if (renderingTarget === 'Apps') { // TODO: update version after new bridget patch is published - hasMinimumBridgetVersion('8.1.0').then( + void hasMinimumBridgetVersion('8.1.0').then( setHorizontalScrollingSupported, ); }