-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typography presets to Storybook #1272
Add typography presets to Storybook #1272
Conversation
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
## What are you changing? - Adds built script to generate CSS for new [web typography presets](https://theguardian.design/2a1e5182b/p/01555f-typography-presets/b/830670) from the existing definitions in the design tokens package and export these as individual variables from Source Foundations - Updates some incorrect font sizes in the design tokens ```bash pnpm nx run @guardian/source-foundations:build-type-presets ``` ```json "textSansBold15": { "$value": { "fontFamily": "{typography.fontFamily.textSans}", "fontSize": "{typography.fontSize.15}", "lineHeight": "{typography.lineHeight.regular}", "fontWeight": "{typography.fontWeight.bold}", "fontStyle": "normal" } }, ``` ⬇️ ```tsx export const textSansBold15 = ` font-family: GuardianTextSans, "Guardian Text Sans Web", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif; font-size: 0.9375rem; line-height: 1.3; font-weight: 700; font-style: normal; `; ```
3d6e725
to
c64629d
Compare
cc58a40
to
bb8c344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect
What are you changing?