Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpctest: minor improvements to the test logger implementation #7475

Open
4 tasks
easwars opened this issue Aug 1, 2024 · 0 comments
Open
4 tasks

grpctest: minor improvements to the test logger implementation #7475

easwars opened this issue Aug 1, 2024 · 0 comments
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. P2 Type: Testing

Comments

@easwars
Copy link
Contributor

easwars commented Aug 1, 2024

I'd like to suggest the following minor improvements to the test logger implementation:

  • Unexport the test logger implementation which is currently a package global here:
    var TLogger *tLogger
    • This would also require moving some methods on this type like ExpectError to be functions in the package
  • Make the above package global accessed atomically from tests. We have had test failures because of data races in the past because of this.
  • Change receiver names in method of the tLogger type to be tl instead of g
@purnesh42H purnesh42H added the Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. P2 Type: Testing
Projects
None yet
Development

No branches or pull requests

2 participants