-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Translations #12
Comments
adding modifications to the dump rake task should be a simple way of doing it, I don't think anyone is using the live-data anyway ... |
Certainly so I did a quick run through on our side, and it looks to be a bit more widespread then i thought. Mainly the XH translation is covered in duplicates. Basically any name that is used twice for a given translation is a smell wouldn't you say? |
yep, sounds good On Thu, Mar 12, 2015 at 1:31 PM, rpo [email protected] wrote:
|
here are two of the issues -- they are both in the XH file!! $ grep BZ cache/file_data_provider/countries* | grep Belg $ grep UG cache/file_data_provider/countries* | grep Cana let's see.. $ git blame cache/file_data_provider/countries-XH.txt | grep Cana $ git blame cache/file_data_provider/countries-XH.txt | grep Belg So is XH an auto-generated file? Would it be a safe heuristic/test to say that the same string for a country can not map to more than one Alpha2 code? At least for some languages? |
idk .. just hit regenerate and see if that fixes it ? On Thu, Mar 12, 2015 at 10:07 PM, Tilo [email protected] wrote:
|
so I can confirm that the bugs are upstream in the pkg_isocodes. My favorite is the US virgin Islands are called "Finland" Canda Finland The XH language appears to be south african but there is no way this translation file is "quality". http://en.wikipedia.org/wiki/Xhosa_language |
maybe using cldr as datasource would give better results :( On Fri, Mar 13, 2015 at 6:43 AM, rpo [email protected] wrote:
|
Maybe so. Regardless CLDR seems much more approachable then the debian source does. It comes down in JSON which is nice 😄 |
@grosser i would almost kill the XH translation all together... it doesn't even look like anything is translated. |
go crazy :) On Tue, Mar 17, 2015 at 1:19 AM, rpo [email protected] wrote:
|
So thank you for this great gem. We have recently swapped out the countries gem to leverage the i18n_data and we have found some issues, that are rooted in some bad translations. What is the best ways to get these corrected? As the debian repo's aren't exactly "approachable".
See countries/countries#243 (comment)
The text was updated successfully, but these errors were encountered: