common: remove librpmem rpmemd libfabric support

Author: wlemkows

.github/workflows/coverity.yml

@@ -16,7 +16,6 @@ env:
   PMDK_CC:        gcc
   PMDK_CXX:       g++
   MAKE_PKG:       0
-  REMOTE_TESTS:   1
   VALGRIND:       1
 
 jobs:

.github/workflows/gha.yml

@@ -20,7 +20,6 @@ jobs:
       PMDK_CC:        gcc
       PMDK_CXX:       g++
       MAKE_PKG:       0
-      REMOTE_TESTS:   1
       VALGRIND:       1
       SRC_CHECKERS:   0
     strategy:
@@ -31,9 +30,9 @@ jobs:
                  "N=4 OS=ubuntu OS_VER=22.04 PMDK_CC=clang PMDK_CXX=clang++ TEST_BUILD=nondebug",
                  "N=5 OS=fedora OS_VER=35    PMDK_CC=clang PMDK_CXX=clang++ TEST_BUILD=debug",
                  "N=6 OS=fedora OS_VER=35    PMDK_CC=clang PMDK_CXX=clang++ TEST_BUILD=nondebug AUTO_DOC_UPDATE=1",
-                 "N=7 OS=fedora OS_VER=35    MAKE_PKG=1 EXPERIMENTAL=y REMOTE_TESTS=0 VALGRIND=0 PMEMSET_INSTALL=y PUSH_IMAGE=1",
-                 "N=8 OS=ubuntu OS_VER=22.04 MAKE_PKG=1 EXPERIMENTAL=y REMOTE_TESTS=0 VALGRIND=0 NDCTL_ENABLE=n PMEMSET_INSTALL=y PUSH_IMAGE=1",
-                 "N=9 OS=ubuntu OS_VER=22.04 MAKE_PKG=1 EXPERIMENTAL=y REMOTE_TESTS=0 VALGRIND=0 NDCTL_ENABLE=n PMDK_CC=clang PMDK_CXX=clang++",
+                 "N=7 OS=fedora OS_VER=35    MAKE_PKG=1 EXPERIMENTAL=y VALGRIND=0 PMEMSET_INSTALL=y PUSH_IMAGE=1",
+                 "N=8 OS=ubuntu OS_VER=22.04 MAKE_PKG=1 EXPERIMENTAL=y VALGRIND=0 NDCTL_ENABLE=n PMEMSET_INSTALL=y PUSH_IMAGE=1",
+                 "N=9 OS=ubuntu OS_VER=22.04 MAKE_PKG=1 EXPERIMENTAL=y VALGRIND=0 NDCTL_ENABLE=n PMDK_CC=clang PMDK_CXX=clang++",
                 "N=10 OS=ubuntu OS_VER=22.04 COVERAGE=1 FAULT_INJECTION=1 TEST_BUILD=debug"]
     steps:
        - name: Clone the git repo

.travis.yml

@@ -18,15 +18,14 @@ env:
     - MAKE_PKG=0
     - PMDK_CC=gcc
     - PMDK_CXX=g++
-    - REMOTE_TESTS=1
     - VALGRIND=1
     - SRC_CHECKERS=0
     - EXPERIMENTAL=n
   jobs:
     - FAULT_INJECTION=1 TEST_BUILD=debug PUSH_IMAGE=1
     - OS=fedora OS_VER=31 PMDK_CC=clang PMDK_CXX=clang++ TEST_BUILD=nondebug PUSH_IMAGE=1
-    - MAKE_PKG=1 REMOTE_TESTS=0 VALGRIND=0
-    - MAKE_PKG=1 REMOTE_TESTS=0 VALGRIND=0 OS=fedora OS_VER=31
+    - MAKE_PKG=1 VALGRIND=0
+    - MAKE_PKG=1 VALGRIND=0 OS=fedora OS_VER=31
     - COVERAGE=1 FAULT_INJECTION=1 TEST_BUILD=debug
 
 jobs:

CODING_STYLE.md

@@ -106,8 +106,8 @@ conventions for git commit messages:
   with an area name and then a colon.  There should be no period after
   the short summary.
 - Valid area names are: **pmem, pmem2, obj, blk, log, set,
-  test, doc, daxio, pmreorder, pool** (for *libpmempool* and *pmempool*), **rpmem**
-  (for *librpmem* and *rpmemd*), **benchmark, examples, core** and **common** (for everything else).
+  test, doc, daxio, pmreorder, pool** (for *libpmempool* and *pmempool*),
+  **benchmark, examples, core** and **common** (for everything else).
 - It is acceptable for the short summary to be the only thing in the commit
   message if it is a trivial change.  Otherwise, the second line must be
   a blank line.

Makefile

@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
-# Copyright 2014-2021, Intel Corporation
+# Copyright 2014-2022, Intel Corporation
 
 #
 # Makefile -- top-level Makefile for PMDK
@@ -8,13 +8,10 @@
 #
 # Use "make doc" to build documentation.
 #
-# Use "make test" to build unit tests. Add "SKIP_SYNC_REMOTES=y" to skip
-# or "FORCE_SYNC_REMOTES=y" to force syncing remote nodes if any is defined.
+# Use "make test" to build unit tests.
 #
 # Use "make check" to run unit tests.
 #
-# Use "make check-remote" to run only remote unit tests.
-#
 # Use "make clean" to delete all intermediate files (*.o, etc).
 #
 # Use "make clobber" to delete everything re-buildable (binaries, etc.).
@@ -45,7 +42,6 @@ RPM_BUILDDIR=rpmbuild
 DPKG_BUILDDIR=dpkgbuild
 EXPERIMENTAL ?= n
 BUILD_PACKAGE_CHECK ?= y
-BUILD_RPMEM ?= y
 TEST_CONFIG_FILE ?= "$(CURDIR)"/src/test/testconfig.sh
 PMEMSET_INSTALL ?= n
 DOC ?= y
@@ -78,14 +74,6 @@ endif
 	$(RM) -r $(RPM_BUILDDIR) $(DPKG_BUILDDIR) rpm dpkg
 	$(RM) -f $(GIT_VERSION)
 
-require-rpmem:
-ifneq ($(BUILD_RPMEM),y)
-	$(error ERROR: cannot run remote tests because $(BUILD_RPMEM_INFO))
-endif
-
-check-remote: require-rpmem all
-	$(MAKE) -C src $@
-
 test check pcheck pycheck: all
 	$(MAKE) -C src $@
 
@@ -108,7 +96,7 @@ check-license:
 	@echo Done.
 
 check-doc: doc
-	BUILD_RPMEM="$(BUILD_RPMEM)" utils/check-manpages
+	./utils/check-manpages
 
 sparse:
 	$(MAKE) -C src sparse
@@ -126,7 +114,7 @@ pkg-clean:
 rpm dpkg: pkg-clean
 	$(MAKE) source DESTDIR="$(DESTDIR)"
 	+utils/build-$@.sh -t $(SRCVERSION) -s "$(DESTDIR)"/pmdk -w "$(DESTDIR)" -o $(CURDIR)/$@\
-			-e $(EXPERIMENTAL) -c $(BUILD_PACKAGE_CHECK) -r $(BUILD_RPMEM)\
+			-e $(EXPERIMENTAL) -c $(BUILD_PACKAGE_CHECK)\
 			-f $(TEST_CONFIG_FILE) -n $(NDCTL_ENABLE) -l $(PMEMSET_INSTALL)
 
 install: all
@@ -138,5 +126,5 @@ ifeq ($(DOC),y)
 endif
 
 .PHONY: all clean clobber test check cstyle check-license install uninstall\
-	source rpm dpkg pkg-clean pcheck check-remote format doc require-rpmem\
+	source rpm dpkg pkg-clean pcheck format doc\
 	$(SUBDIRS)

README.md

@@ -33,7 +33,6 @@ Bugs and feature requests for this repo are tracked in our [GitHub Issues Databa
 	* [Testing Libraries](#testing-libraries-on-windows)
 8. [Debugging](#debugging)
 9. [Experimental Packages](#experimental-packages)
-	* [librpmem and rpmemd packages](#the-librpmem-and-rpmemd-packages)
 	* [Experimental support for 64-bit ARM](#experimental-support-for-64-bit-arm)
 10. [Contact Us](#contact-us)
 
@@ -56,10 +55,8 @@ Libraries available in this repository:
 
 - [libpmemset](https://pmem.io/pmdk/libpmemset/):  (**still in progress**) aims to provide the core functionality any persistent application should have. (EXPERIMENTAL)
 
-- [librpmem](https://pmem.io/pmdk/librpmem/)<sup>1</sup>:  provides low-level support for remote access to persistent memory utilizing RDMA-capable RNICs. (DEPRECATED)
-
-**Librpmem** library is deprecated. If you are interested in a remote persistent
-memory support please look at new library [rpma](https://github.com/pmem/rpma).
+**Librpmem** library has been removed from PMDK repository. If you are interested in a remote persistent
+memory support please look at new [librpma](https://github.com/pmem/rpma).
 
 If you're looking for *libvmem* and *libvmmalloc*, they have been moved to a
 [separate repository](https://github.com/pmem/vmem).
@@ -77,7 +74,7 @@ For information on how these libraries are licensed, see our [LICENSE](LICENSE)
 >
 ><sup>2</sup> PMDK for Windows is feature complete, but not yet considered production quality.
 >
-><sup>3</sup> DAX and **libfabric** are not yet supported in FreeBSD, so at this time PMDK is available as a technical preview release for development purposes.
+><sup>3</sup> DAX is not yet supported in FreeBSD, so at this time PMDK is available as a technical preview release for development purposes.
 
 ## Getting Started
 
@@ -141,8 +138,6 @@ You will need to install the following required packages on the build system:
 The following packages are required only by selected PMDK components
 or features:
 
-* **libfabric** (v1.4.2 or later) -- required by **librpmem**
-
 ><sup>1</sup> PMDK depends on libndctl to support RAS features. It is possible
 to disable this support by passing NDCTL_ENABLE=n to "make", but we strongly
 discourage users from doing that. Disabling NDCTL strips PMDK from ability to

doc/Makefile

@@ -147,17 +147,6 @@ MANPAGES_3_DUMMY += libpmemset/pmemset_config_delete.3 libpmemset/pmemset_delete
 		    libpmemset/pmemset_source_pwrite_mcsafe.3
 endif
 
-ifeq ($(BUILD_RPMEM),y)
-MANPAGES_7_MD += librpmem/librpmem.7.md
-MANPAGES_3_MD += librpmem/rpmem_create.3.md
-MANPAGES_3_MD += librpmem/rpmem_persist.3.md
-MANPAGES_1_MD += rpmemd/rpmemd.1.md
-MANPAGES_3_DUMMY += librpmem/rpmem_open.3 librpmem/rpmem_set_attr.3 librpmem/rpmem_close.3 \
-		    librpmem/rpmem_read.3 librpmem/rpmem_remove.3 librpmem/rpmem_check_version.3 \
-		    librpmem/rpmem_errormsg.3 librpmem/rpmem_deep_persist.3 librpmem/rpmem_flush.3 \
-		    librpmem/rpmem_drain.3
-endif
-
 ifeq ($(NDCTL_ENABLE),y)
 MANPAGES_1_MD += daxio/daxio.1.md
 endif

doc/README

@@ -28,8 +28,6 @@ libpmemobj -- transactional object store
 libpmempool -- persistent memory pool management library
 pmempool -- persistent memory pool management tool
 libpmemset -- core functionality for any persistent application (EXPERIMENTAL)
-librpmem -- remote access to persistent memory (DEPRECATED)
-rpmemd -- remote persistent memory daemon (DEPRECATED)
 daxio -- perform I/O on Device DAX device
 
 These man pages provide the API specification for the corresponding libraries

doc/libpmemobj/pmemobj_open.3.md

@@ -9,7 +9,7 @@ header: "pmemobj API version 2.3"
 ---
 
 [comment]: <> (SPDX-License-Identifier: BSD-3-Clause)
-[comment]: <> (Copyright 2017-2021, Intel Corporation)
+[comment]: <> (Copyright 2017-2022, Intel Corporation)
 
 [comment]: <> (pmemobj_open.3 -- man page for most commonly used functions from libpmemobj library)
 
@@ -80,8 +80,7 @@ from the size of the existing file and will verify that the file appears to be
 empty by searching for any non-zero data in the pool header at the beginning of
 the file. The minimum net pool size allowed by the library for a local
 transactional object store is defined in **\<libpmemobj.h\>** as
-**PMEMOBJ_MIN_POOL**. _WINUX(,=q=For remote replicas the minimum file size
-is defined in **\<librpmem.h\>** as **RPMEM_MIN_PART**.=e=)
+**PMEMOBJ_MIN_POOL**.
 
 Depending on the configuration of the system, the available non-volatile
 memory space may be divided into multiple memory devices.

doc/libpmempool/pmempool_check_init.3.md

@@ -9,7 +9,7 @@ header: "pmempool API version 1.3"
 ---
 
 [comment]: <> (SPDX-License-Identifier: BSD-3-Clause)
-[comment]: <> (Copyright 2017-2018, Intel Corporation)
+[comment]: <> (Copyright 2017-2022, Intel Corporation)
 
 [comment]: <> (pmempool_check_init.3 -- man page for pmempool health check functions)
 
@@ -145,8 +145,6 @@ the same structure (the same number of parts with exactly the same size) as the
 
 Backup is supported only if the source *pool set* has no defined replicas.
 
-Neither *path* nor *backup_path* may specify a pool set with remote replicas.
-
 The _UW(pmempool_check) function starts or resumes the check indicated by *ppc*.
 When the next status is generated, the check is paused and _UW(pmempool_check)
 returns a pointer to the _UWS(pmempool_check_status) structure: