Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoScroll Improvement like muuri.dev #2870

Open
depak379mandal opened this issue Nov 18, 2024 · 12 comments
Open

AutoScroll Improvement like muuri.dev #2870

depak379mandal opened this issue Nov 18, 2024 · 12 comments

Comments

@depak379mandal
Copy link

depak379mandal commented Nov 18, 2024

Need Scroll on drag improvement like https://muuri.dev

I think there are many issues related to this #2728 #2666 and many more

I just wanted to have it clean scroll on drag for every device, I also want to donate for this You are maintaining and doing great stuff with hard work. I really appreciate your work @adumesny. If you confirm, I will donate $200 right now for your time. That is how much I have. Let me know what do you think. I also think everyone should donate for this great project, whoever using this project. I am using react grid layout, but want to switch to gridstack, but need only scroll on drag to be fixed.

@depak379mandal depak379mandal changed the title AutoScroll like muuri.dev Improvement AutoScroll Improvement like muuri.dev Nov 18, 2024
@adumesny
Copy link
Member

@depak379mandal thank you for the recognition but you need to be very specific about what scrolling use case you need be looked at as there are many areas to look at - can't boil the ocean. Also you will need others to pitch in as that amount is unortunately very small given the amount of work scrolling can be.

took a quick look at muuri and not sure what scrolling you compare to.

Also curious on what react grid layout (I assume you mean react-grid-layout) not working for you. I hear people switch to gridstack from it regularly, even though we don't have a bundle react wrapper yet. working on it...

@depak379mandal
Copy link
Author

depak379mandal commented Nov 18, 2024

Thanks for the reply @adumesny Let me prepare videos, It is just small fix for scrolling Smoothing and improvements,

The issue
https://drive.google.com/file/d/1Thfm95AraP2OGspL7I6Ne3OyspfOXMso/view?usp=sharing

The solution in muuri.dev
https://drive.google.com/file/d/190TgFrwBti9QJxgV3No1QyfEwK74FqV2/view?usp=sharing

Will be great to have it with mobile touch for native too, So I will switch my whole project gridstack and can also contribute to amazing library.

Also donated, Thank you

@depak379mandal
Copy link
Author

@adumesny Can you reply? Love to hear from your side.

@adumesny
Copy link
Member

hey, took a look at the video and you are talking about entire page scrolling (which could technically have nested scrollbars so each would be to scroll up until you reach top, then switch to the next higher, then...
updateScrollPosition() and updateScrollResize() are used for scrolling but I havn't looked at that code in a very long time..

super busy during the week and only have time on weekend, beside I didn't say I could work on this for the small donation you gave, but I do appreciate the suport.

@depak379mandal
Copy link
Author

@adumesny
It would be great, to have this feature. Just a small scrolling fix. You have very best knowledge of it. Just wanted to contribute to this library. Also, will be contributing, If you got some time to improve this. Please let me know.

I even never used this library but wanted to switch, It will be very motivating if you are able to resolve this issue. I really appreciate and respect your time, that is why I donated as much as I can.

@depak379mandal
Copy link
Author

@adumesny If you don't have time and not wanted to work on this, Can you please give back the donation, I will approach to other library. Let me know.

@depak379mandal
Copy link
Author

depak379mandal commented Dec 11, 2024

Hello @adumesny , I implemented scroll fix in here https://www.npmjs.com/package/danimai-gridstack, Please improvise it here, if you got time. I really loved the library, but need your support. Already implemented the concept, it is working but can be improvised. And we can make gridstack js perfect.

@adumesny
Copy link
Member

adumesny commented Dec 13, 2024

this is great! but can you please submit a code review instead for me to check and take a look ? thank you.

@lorenzogonnelli
Copy link

lorenzogonnelli commented Dec 16, 2024

@adumesny, the way you are handling this issue is completely unacceptable to be honest. @depak379mandal donated $200 in good faith, even tried to fix the issue himself, and still, there’s been little or no effort from your side. Your attitude has been dismissive and hostile, despite the support. It's been weeks of waiting with no effort made on your end. Even donating, the lack of professionalism and disregard for your community’s support is frustrating. At this point, it’s hard to justify continuing with this library when basic issues are being ignored

@adumesny
Copy link
Member

@lorenzogonnelli sorry you feel that way. I had personal issues this past weekend and could not work on this beloved library... I do this on my own spare time, and don't get paid for this. If you think $200 (which by the way I never asked/agreed upon, but very much appreciate) is enough for me to drop work to take a look, it maybe pays for 1h.

I only asked for those changes to be pushed in a CL so I can easily review and commit with possible fixes rather than hunt a personal branch. Not sure what's hostile about that. If you maintain a lib and have dozens of people ask for things, and do this on your own spare time, you might understand.

@lorenzogonnelli
Copy link

lorenzogonnelli commented Dec 17, 2024

@adumesny It's not necessarily what you asked that comes across as hostile, but how you asked it. There’s no gratitude shown for the people contributing to this project—people doing work that, in theory, should be your responsibility.

It’s also worth noting that you regularly ask for donations, even for minor fixes. This is likely why someone donated without you explicitly requesting it this time. The fix itself isn’t complicated, and you are clearly the most qualified person to address it.

I raised my issue months ago and never received any feedback beyond being told to ‘donate to get it fixed.’ Yet, even with donations, nothing seems to change. At this point, it might be fair to label this library as unmaintained.

This bug affects every Apple user, making the library unusable on Apple devices. We’re asking politely for a fix, but there seems to be little interest or initiative on your side. I know you have personal issues and other priorities to deal with, but please understand this is a serious problem, and we truly need your help. This issue is causing significant problems for us, and you’re the only one in a position to resolve it.

Thank you.

ps. At least you edited your last reply lol

@adumesny
Copy link
Member

adumesny commented Dec 17, 2024

@lorenzogonnelli #2666 must be the issue you are referring to. If you read my last comment, I said I could take a look if I could duplicate this on my machine using emulation mode (windows+chrome) and to reach out on slack to cover that work, but you never did...

this is an open source, is free, use a lot of my spare time, and you are welcome to fix things yourself, and there is no guarantee that I would fix what is important to you. When you say it won't let me use this library for my ios customers clearly you are getting paid to use this and expect me to fix things for you right away and for free ? give me a break.

maintaining an open source is a thankless job and people like you make me want to drop this, or make it licensed paid version only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants