Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion/button] Buttons: Chips or Button? (when containing avatar) #6

Open
dusskapark opened this issue Nov 19, 2020 · 4 comments

Comments

@dusskapark
Copy link

Screen Shot 2020-11-17 at 2 47 47 PM

@dusskapark
Copy link
Author

클릭하면 해당 가수의 페이지로 이동하는 것 같습니다..
일단 저는 Chips로 봤기 때문에 라벨링 하지 않았습니다.

대신 안에 얼굴만 아바타로 라벨링했습니다.

@softmarshmallow
Copy link
Member

In my opinion, that should be considered as Button. Be cause, once this is considered as chip, first it should have been inside some Wrap layout so the chips can be aligned in some rules. but in this case, the layout seems aligned left and right. so It's not inside Wrap. -> meanwhile, process it as a Button.

Second thoughts?

@softmarshmallow softmarshmallow changed the title Buttons: 이것은 Chips 일까요? Buttons 일까요? [discussion/button] Buttons: Chips or Button? (when containing avatar) Nov 19, 2020
@giyoon
Copy link

giyoon commented Dec 2, 2020

스크린샷 2020-12-02 오후 6 33 08

chips는 button으로 라벨링 안하면 되는 것으로 이해했습니다. 맞을까요?

@dusskapark
Copy link
Author

dusskapark commented Dec 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants