Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our playwright container #529

Open
ribalba opened this issue Nov 6, 2023 · 3 comments
Open

Fix our playwright container #529

ribalba opened this issue Nov 6, 2023 · 3 comments

Comments

@ribalba
Copy link
Member

ribalba commented Nov 6, 2023

Docker scout gives us quite a few errors:

Screenshot 2023-11-06 at 21 02 32
@ArneTR
Copy link
Member

ArneTR commented Nov 7, 2023

This is also an old image. We do not support the :latest anymore. v3 is the neweset.

Also that has some old libraries though. The question is if we want to override what the base package maintainer gives us?

We could with an apt update ... and a pip install --upgrade pip

Both should be no problem I guess?

@dan-mm What do you think? Can you apply those fixes and update the image?

@dan-mm
Copy link
Contributor

dan-mm commented Nov 9, 2023

The Dockerfile for this currently does:

# Install dependencies
RUN apt-get update && apt-get install -y  curl  wget  gnupg  && rm -rf /var/lib/apt/lists/*

# Install Playwright
RUN pip install playwright

I can add pip-install --upgrade pip to this, but its already doing apt-get update. Will doing just an 'apt update' do anything extra?

@ArneTR
Copy link
Member

ArneTR commented Nov 9, 2023

Including an apt upgrade of course. This is what I meant by ...

TBD next office meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants