Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions between different image sizes #18

Open
chenchix opened this issue Nov 11, 2016 · 4 comments
Open

Transitions between different image sizes #18

chenchix opened this issue Nov 11, 2016 · 4 comments
Assignees

Comments

@chenchix
Copy link

If you load two images with different dimmensions, transitions is pretty weird.

Is there any thing I am missing?

@gre
Copy link
Owner

gre commented May 15, 2017

hi, I'm aware of this, i'm going to address it soon!

@gre gre self-assigned this May 15, 2017
@gre
Copy link
Owner

gre commented May 30, 2017

status

gre added a commit that referenced this issue Aug 9, 2017
@zamirkhan
Copy link

zamirkhan commented Oct 5, 2017

Is the resizeMode in gl-transition lib currently in a working state? I don't notice a difference in behaviour (it all looks like "stretch" to me) when I specify 'cover' or 'contain' in createTransition.

@gre
Copy link
Owner

gre commented Oct 6, 2017

in gl-transition this should be supported:

createTransition(gl, transition, { resizeMode: "cover" })

maybe there is a bug?

the remaining lib that is not supported yet is react-gl-transition (in a branch)

@gre gre removed their assignment Oct 27, 2017
@gre gre self-assigned this Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants