-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acquia packages & External Library are not supported in composerize process #46
Comments
That's because drupal/acquia_cms isn't a real project, right? |
You just need to create an exception for acquia packages here: https://github.com/grasmash/composerize-drupal/blob/master/src/Composer/ComposerizeDrupalCommand.php#L176 If it's one of cohesion, cohesion_theme, acquia_cms, lightning, etc., then use an |
@grasmash we have one more case, when other library for ex- |
Same fix either way. Something like: <?php
$exceptions = [
'acquia_cms' => 'acquia/acquia_cms',
'idfive' => 'idfive/idfive',
];
foreach ($projects as $project_name => $project) {
if (array_key_exists($project, $exceptions)) {
$package_name = $exceptions[$project];
}
else {
$package_name = "drupal/$project_name";
} |
ok, I need to figure out how many docroots that are failed with external library and need to create PR for this. |
Is there a way to determine vendor names from drupal config files? |
I don't think so. |
@grasmash
As per analysis & investigation, we identified in Drupal composerize process is not supported for acquia packages & External Library.
For this reason some of the docroot not able to composerize by ra-up process.
FYR - https://github.com/grasmash/composerize-drupal/pull/45/files
The text was updated successfully, but these errors were encountered: