Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer returns invalid SDL if Block String comment contains double-quote #677

Open
kevinmichaelchen opened this issue Sep 4, 2023 · 0 comments

Comments

@kevinmichaelchen
Copy link

If Block String comment contains a double-quote, the resulting printed SDL will be invalid.

Example problem

Suppose you have the following schema:

"""
Representation of a "Foo"
"""
type Foo {
  name: String
}

if you parse this schema to an AST document, and then print the document to an SDL string (as shown in schema_printer_test.go, then you end up with:

"""Representation of a "Foo""""
type Foo {
  name: String
}

Notice the extra double-quote 😢

Example solution

One workaround is to remove the double quotes from the comment.

Even something like this would work fine:

"""
Representation of a Foo
"""
type Foo {
  name: String
}
@kevinmichaelchen kevinmichaelchen changed the title Printer returns invalid SDL if Block String Printer returns invalid SDL if Block String comment contains double-quote Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant