GraphQL Client is not able to reconnect if graphQL server restart #180

akoliya003 · 2020-03-04T16:06:45Z

Hi,

GraphQL Client is not able to reconnect if graphQL server restart.
In my local copy below is the change I have added.

GraphQL.Client --> Http --> GraphQLHttpWebSocket.cs --> _receiveResultAsync(...) --> 
			.....
                         catch (Exception e)
			{
				**await _closeAsync().ConfigureAwait(false);
				clientWebSocket?.Dispose();**
				Debug.WriteLine($"exception thrown while receiving websocket data: {e}");
				throw;
			}

You may also have some better way.

-----------------------------------------------------------------------------------------------
WebSocketException: The remote party closed the WebSocket connection without completing the close handshake. (WebSocketError ConnectionClosedPrematurely, ErrorCode 0, NativeErrorCode 0
WebSocketException: The remote party closed the WebSocket connection without completing the close handshake. (WebSocketError ConnectionClosedPrematurely, ErrorCode 0, NativeErrorCode 0
System.NullReferenceException: Object reference not set to an instance of an object.
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebsocketHelpers.<>c__DisplayClass0_0`1.<CreateSubscriptionStream>b__3(Exception e)
System.Net.WebSockets.WebSocketException (0x80004005): The remote party closed the WebSocket connection without completing the close handshake. ---> System.IO.IOException: Unable to transfer data on the transport connection: Broken pipe. ---> System.Net.Sockets.SocketException: Broken pipe
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Net.WebSockets.ManagedWebSocket.<SendFrameFallbackAsync>d__56.MoveNext()
   at System.Net.WebSockets.ManagedWebSocket.<SendFrameFallbackAsync>d__56.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebSocket.<_sendWebSocketRequest>d__24.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebsocketHelpers.<>c__DisplayClass0_0`1.<<CreateSubscriptionStream>b__5>d.MoveNext()

The text was updated successfully, but these errors were encountered:

rose-a · 2020-03-04T19:31:15Z

I'm aware of an issue with the reconnect capability, seems there is a threading problem within the observable chain... Hopefully I'll be able to fix this in the coming days

akoliya003 · 2020-03-04T19:32:49Z

Hi Alexander, Thanks for your prompt reply on this. Appreciate your help. Thanks, Bhavesh

…

On Wed, Mar 4, 2020 at 1:31 PM Alexander Rose ***@***.***> wrote: I'm aware of an issue with the reconnect capability, seems there is a threading problem within the observable chain... Hopefully I'll be able to fix this in the coming days — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#180?email_source=notifications&email_token=AIYRHNCJDVHHSPYGHFZW7FDRF2UAHA5CNFSM4LBL7GB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENZZX6Y#issuecomment-594779131>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIYRHNF2RVCNKZKRRS75FGDRF2UAHANCNFSM4LBL7GBQ> .

rose-a · 2020-03-04T19:55:25Z

The exception is as expected and you cannot call closeAsync() there because the websocket is in an aborted state. This is taken care of by InitializeWebSocket() which disposes the old websocket instance if it's in a bad state and creates a new one...

This should automatically happen through the Retry() method in the subscriptions observable chain.

Maybe you could configure a custom GraphQLHttpClientOptions.BackOffStrategy and check if this method is invoked after you shut down the server?

rose-a · 2020-03-04T20:01:09Z

Somehow this seems to be related with #161...

akoliya003 · 2020-03-04T20:14:07Z

I tried adding custom GraphQLHttpClientOptions.BackOffStrategy and checked that method is not invoked at all.

Instead of retries it raise below exception:

-------
WebSocketException: The remote party closed the WebSocket connection without completing the close handshake. (WebSocketError ConnectionClosedPrematurely, ErrorCode 0, NativeErrorCode 0
WebSocketException: The remote party closed the WebSocket connection without completing the close handshake. (WebSocketError ConnectionClosedPrematurely, ErrorCode 0, NativeErrorCode 0
System.NullReferenceException: Object reference not set to an instance of an object.
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebsocketHelpers.<>c__DisplayClass0_0`1.<CreateSubscriptionStream>b__3(Exception e)
System.Net.WebSockets.WebSocketException (0x80004005): The remote party closed the WebSocket connection without completing the close handshake. ---> System.IO.IOException: Unable to transfer data on the transport connection: Broken pipe. ---> System.Net.Sockets.SocketException: Broken pipe
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Net.WebSockets.ManagedWebSocket.<SendFrameFallbackAsync>d__56.MoveNext()
   at System.Net.WebSockets.ManagedWebSocket.<SendFrameFallbackAsync>d__56.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebSocket.<_sendWebSocketRequest>d__24.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebsocketHelpers.<>c__DisplayClass0_0`1.<<CreateSubscriptionStream>b__5>d.MoveNext()
---------------

akoliya003 · 2020-03-04T20:46:58Z

What i understood. Once GraphQL server restarts, it disconnect the connection. At this point at client side _receiveResultAsync(...) method throw an exception and that exception all the way pass to application and no retry is called in this flow. As per me as soon we get exception in that method we should trigger retries and trigger invalidate existing socket so InitializeWebSocket(..) will take care on next read request. If i start GraphQL client application first and then start the server then it works fine as graphQL client application keep trying to reconnect and finally connects with server once it is up and running. I hope. This information will help.

…

On Wed, Mar 4, 2020 at 2:01 PM Alexander Rose ***@***.***> wrote: Somehow this seems to be related with #161 <#161>... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#180?email_source=notifications&email_token=AIYRHNEDKUFLL3N2GPBYKD3RF2XQNA5CNFSM4LBL7GB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENZ7GEI#issuecomment-594801425>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIYRHNDCAU7ZRML2YSZOTUDRF2XQNANCNFSM4LBL7GBQ> .

rose-a · 2020-03-09T09:17:19Z

that exception all the way pass to application

Where does that exception surface? Does it call OnError on your subscription?

akoliya003 · 2020-03-11T16:14:49Z

Yes,

Below is the Exception details:

----------------------
testGraphQL.WScoreUpdate
WebSocketException: The remote party closed the WebSocket connection without completing the close handshake. (WebSocketError ConnectionClosedPrematurely, ErrorCode 424189040, NativeErrorCode 424189040
WebSocketException: The remote party closed the WebSocket connection without completing the close handshake. (WebSocketError ConnectionClosedPrematurely, ErrorCode 0, NativeErrorCode 0
System.NullReferenceException: Object reference not set to an instance of an object.
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebsocketHelpers.<>c__DisplayClass0_0`1.<CreateSubscriptionStream>b__3(Exception e)
System.Net.WebSockets.WebSocketException (0x80004005): The remote party closed the WebSocket connection without completing the close handshake. ---> System.IO.IOException: Unable to transfer data on the transport connection: Broken pipe. ---> System.Net.Sockets.SocketException: Broken pipe
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Net.WebSockets.ManagedWebSocket.<SendFrameFallbackAsync>d__56.MoveNext()
   at System.Net.WebSockets.ManagedWebSocket.<SendFrameFallbackAsync>d__56.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebSocket.<_sendWebSocketRequest>d__24.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GraphQL.Client.Http.Websocket.GraphQLHttpWebsocketHelpers.<>c__DisplayClass0_0`1.<<CreateSubscriptionStream>b__5>d.MoveNext()
----------

rose-a · 2020-03-16T10:49:10Z

Did you pass a custom exception handler? This exception is normally swallowed by and causes a Retry on the subscription.

Please also update to the latest version of this lib, as I made some optimizations to the code behind...

rose-a added the bug Something isn't working label Mar 4, 2020

tpurschke mentioned this issue Jun 14, 2022

config subscription exception in middleware server floods mw log CactuseSecurity/firewall-orchestrator#1731

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GraphQL Client is not able to reconnect if graphQL server restart #180

GraphQL Client is not able to reconnect if graphQL server restart #180

akoliya003 commented Mar 4, 2020 •

edited by rose-a

Loading

rose-a commented Mar 4, 2020

akoliya003 commented Mar 4, 2020 via email

rose-a commented Mar 4, 2020 •

edited

Loading

rose-a commented Mar 4, 2020

akoliya003 commented Mar 4, 2020 •

edited by rose-a

Loading

akoliya003 commented Mar 4, 2020 via email

rose-a commented Mar 9, 2020

akoliya003 commented Mar 11, 2020 •

edited by rose-a

Loading

rose-a commented Mar 16, 2020

GraphQL Client is not able to reconnect if graphQL server restart #180

GraphQL Client is not able to reconnect if graphQL server restart #180

Comments

akoliya003 commented Mar 4, 2020 • edited by rose-a Loading

rose-a commented Mar 4, 2020

akoliya003 commented Mar 4, 2020 via email

rose-a commented Mar 4, 2020 • edited Loading

rose-a commented Mar 4, 2020

akoliya003 commented Mar 4, 2020 • edited by rose-a Loading

akoliya003 commented Mar 4, 2020 via email

rose-a commented Mar 9, 2020

akoliya003 commented Mar 11, 2020 • edited by rose-a Loading

rose-a commented Mar 16, 2020

akoliya003 commented Mar 4, 2020 •

edited by rose-a

Loading

rose-a commented Mar 4, 2020 •

edited

Loading

akoliya003 commented Mar 4, 2020 •

edited by rose-a

Loading

akoliya003 commented Mar 11, 2020 •

edited by rose-a

Loading