New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all the TypeScript types are valid from both CJS and ESM #482

Open

benjie opened this issue Aug 21, 2023 · 0 comments

Labels

🙏 help-wanted 🔬 research

Milestone

Member

benjie commented Aug 21, 2023

https://arethetypeswrong.github.io/?p=postgraphile%405.0.0-beta.6

ref https://blog.isquaredsoftware.com/2023/08/esm-modernization-lessons/

CJS default export
CommonJS module simulates a default export with exports.default and exports.__esModule, but does not also set module.exports for compatibility with Node. Node, and some bundlers under certain conditions, do not respect the __esModule marker, so accessing the intended default export will require a .default property access on the default import.

benjie added the 🔬 research label

benjie added this to the V5 RC milestone

benjie added the 🙏 help-wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment