Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards version 3 #199

Closed
jakob-keller opened this issue Aug 19, 2022 · 6 comments
Closed

Towards version 3 #199

jakob-keller opened this issue Aug 19, 2022 · 6 comments

Comments

@jakob-keller
Copy link
Contributor

Hello and thanks for this great library!

I recently migrated away from my own primitive sorted container implementation and have never looked back.

There is only one feature that is important to me, but is currently not provided: type hints. And it looks to me as if the community feels the same: #68, #155

I am reasonably experienced with inline type hints and would offer to prepare a PR for that purpose, or pick up the work already done by others: #107, #136

One precondition would be to drop support for EOL Python versions, which is anything older than Python 3.7 at this point. I could draft a corresponding PR, if there is interest.

This might be the ground work for sortedcontainers version 3, to be followed be other issues already tagged as V3.

How does @grantjenks feel about this?

@grantjenks
Copy link
Owner

The V3 tag is just old. I’ve deleted it.

@grantjenks
Copy link
Owner

I use type hints at work and haven’t liked them much. As I said in #68, I’d prefer if someone added support to the type shed and maintained them there for a while.

@jakob-keller
Copy link
Contributor Author

I use type hints at work and haven’t liked them much. As I said in #68, I’d prefer if someone added support to the type shed and maintained them there for a while.

I understand and will look into that. Thanks for clarifying!

@grantjenks
Copy link
Owner

Regarding EOL Python versions, might want to keep Python 3.6 as it’s still the standard in Cent OS 7 which is not yet EOL.

@grantjenks
Copy link
Owner

Otherwise, closing as a dupe of #68 regarding type hints.

@jakob-keller
Copy link
Contributor Author

jakob-keller commented Aug 20, 2022

Regarding EOL Python versions, might want to keep Python 3.6 as it’s still the standard in Cent OS 7 which is not yet EOL.

Fair point. Of course, removing support for CPython 3.6 only affects future releases of sortedcontainers. All existing releases continue to be available e.g. on PyPI and ensure that any dependencies for Cent OS 7 users or elsewhere won't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants