-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards version 3 #199
Comments
The V3 tag is just old. I’ve deleted it. |
I use type hints at work and haven’t liked them much. As I said in #68, I’d prefer if someone added support to the type shed and maintained them there for a while. |
I understand and will look into that. Thanks for clarifying! |
Regarding EOL Python versions, might want to keep Python 3.6 as it’s still the standard in Cent OS 7 which is not yet EOL. |
Otherwise, closing as a dupe of #68 regarding type hints. |
Fair point. Of course, removing support for CPython 3.6 only affects future releases of sortedcontainers. All existing releases continue to be available e.g. on PyPI and ensure that any dependencies for Cent OS 7 users or elsewhere won't break. |
Hello and thanks for this great library!
I recently migrated away from my own primitive sorted container implementation and have never looked back.
There is only one feature that is important to me, but is currently not provided: type hints. And it looks to me as if the community feels the same: #68, #155
I am reasonably experienced with inline type hints and would offer to prepare a PR for that purpose, or pick up the work already done by others: #107, #136
One precondition would be to drop support for EOL Python versions, which is anything older than Python 3.7 at this point. I could draft a corresponding PR, if there is interest.
This might be the ground work for sortedcontainers version 3, to be followed be other issues already tagged as V3.
How does @grantjenks feel about this?
The text was updated successfully, but these errors were encountered: