Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to beautifulsoup4 for Python 3 support? #71

Open
frnsys opened this issue Jan 5, 2014 · 4 comments
Open

Switching to beautifulsoup4 for Python 3 support? #71

frnsys opened this issue Jan 5, 2014 · 4 comments

Comments

@frnsys
Copy link

frnsys commented Jan 5, 2014

Are there any plans to change the beautifulsoup dependency to beautifulsoup4 for Python 3 support? Or are there other factors as well before this will be py3 compatible?

frnsys pushed a commit to frnsys/python-goose that referenced this issue Feb 2, 2014
@frnsys
Copy link
Author

frnsys commented Feb 2, 2014

Please ignore the first of these commits – that one wasn't properly synced with the develop branch.

The latter commit is starting work on a port to Python 3. All tests pass except for tests.extractors.TestExtractChinese because the jieba package is not Py3 compatible.

I tried to preserve Py2.7 compatibility where I could, but I don't have much experiencing porting to Python 3 so the changes need review from someone more experienced.

@grangier
Copy link
Owner

grangier commented Feb 7, 2014

@Ftzeng I'm really interested in your py3 port once it will be functional

xav

@frnsys
Copy link
Author

frnsys commented Feb 7, 2014

I think the two biggest issues with my port so far are:

  • Python 2.7 compatible string unicode/byte handling
  • The BeautifulSoup parser...I believe my workaround sidesteps it entirely in the Python 3 port which is likely not the desired behavior

@vladimir-shmidt
Copy link

suppose in case of porting this would be useless #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants