Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix title cleaning #195

Closed
wants to merge 3 commits into from
Closed

Fix title cleaning #195

wants to merge 3 commits into from

Conversation

slitayem
Copy link

@slitayem slitayem commented Jan 9, 2015

Fixes #194

vetal4444
vetal4444 reviewed Jan 12, 2015
View reviewed changes
goose/extractors/title.py
title = u" ".join(title_words).strip()

# Remove Title splitters
title = u" ".join(re.split('\|| |:|»|-',title)).strip()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, If we have "Title | Cool site" on input, we receive "Title Cool site" in output. I think this double space is not good.

@slitayem
Copy link
Author

@vetal4444 good catch thanks. It is fixed now.

@vetal4444
Copy link

I think this pr still bad for cleaning title. View #196. Your method will return 'GHG Protocol for Cities Greenhouse Gas Protocol'.

@slitayem slitayem closed this Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in title extractor
3 participants
@slitayem @vetal4444 @saloua-cliqz