Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0-length images are included as candidates -- a bug? #112

Open
RobBednark opened this issue May 28, 2014 · 2 comments
Open

0-length images are included as candidates -- a bug? #112

RobBednark opened this issue May 28, 2014 · 2 comments

Comments

@RobBednark
Copy link

In this code from goose.images.extractors.UpgradedImageExtractor.get_images_bytesize_match:

            if (bytes == 0 or bytes > self.images_min_bytes) \
                    and bytes < MAX_BYTES_SIZE:
                good_images.append(image)

if the image retrieved has a length of 0 bytes (bytes == 0), it will be added to good_images. This seems like a bug, no?

@grangier
Copy link
Owner

it seems do you have a real world exemple ?

@RobBednark
Copy link
Author

No, I don't have a real world example. It was just something I saw while looking at the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants