-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle configuration problem in 2.0.7 #222
Comments
Here is Android documentation about dependency configurations. So if add PaperParcel dependency like this:
I cant build my project because classes from So to fix this I have to also declare dependency to
|
Hmm, I wonder why. It looks like it is declared as an API dependency https://github.com/grandstaish/paperparcel/blob/master/paperparcel/build.gradle#L30 |
So I create sample project to check this is not some weird issue with my main project and still got same behavior. apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'
apply plugin: 'kotlin-kapt'
android {
compileSdkVersion 28
defaultConfig {
applicationId "ru.bejibx.koin"
minSdkVersion 21
targetSdkVersion 28
versionCode 1
versionName "1.0"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
buildTypes {
release {
minifyEnabled false
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
}
}
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation"org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
implementation 'androidx.appcompat:appcompat:1.0.2'
implementation 'androidx.core:core-ktx:1.0.2'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.2.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
implementation 'nz.bradcampbell:paperparcel:2.0.8'
implementation 'nz.bradcampbell:paperparcel-kotlin:2.0.8' // Optional
kapt 'nz.bradcampbell:paperparcel-compiler:2.0.8'
} Again, I have to add |
Could this be related to how this library is packaged? Maybe we should update some gradle plugin to properly support new dependency configurations? |
Maybe this will be helpful? Or probably we should update android-maven-gradle-plugin? |
Hi! I think I suddenly break gradle configuration with my recent PR with incap support.
For version 2.0.7 to work properly I have to add both
paperparcel
andpaperparcel-api
artifacts even despite the fact thatpaperparcel-api
declared usingapi
configuration insidepaperparcel
module.The text was updated successfully, but these errors were encountered: