Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete endpoint for trees #390

Open
cdhorn opened this issue Jun 30, 2023 · 3 comments
Open

Delete endpoint for trees #390

cdhorn opened this issue Jun 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@cdhorn
Copy link
Collaborator

cdhorn commented Jun 30, 2023

In a multi-tenant environment a delete endpoint will be needed for users to delete their tree and any associated media items. Likely needed for GDPR compliance. (Did not check code, just glanced at API docs.)

@cdhorn
Copy link
Collaborator Author

cdhorn commented Jun 30, 2023

Other consideration in multi-user environment if user is deleted any trees and associated media of theirs also need to be cleaned up.

Other consideration not sure with GDPR what these things mean for user related data in context of backups.

@DavidMStraub
Copy link
Member

Other consideration not sure with GDPR what these things mean for user related data in context of backups.

Backups need to be deleted, too; for a server administrator, this means it makese sense to backup trees individually, so it's easy to delete all backups of a given tree.

@DavidMStraub
Copy link
Member

DavidMStraub commented Jun 30, 2023

There are some subtleties to take into account:

  • currently, media files are never deleted. DELETE to /api/media/<handle> just deletes the media object from the db. This is perfectly in line with how Gramps handles it: Gramps never deletes files. My take on this so far was that anybody running a server with GDPR requirements would have to set up a script that regularly cleans dangling files
  • deleting a SQLite tree is easy, just delete the database dir, but for Postgres it's much more difficult. Gramps itself does not allow deleting(emptying a Postgres db. So also in that case, I wonder if it wouldn't be easier to have a server-side script, if needed for GDPR

@DavidMStraub DavidMStraub added the enhancement New feature or request label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants