Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring k6 runner blocked hostnames #901

Open
ka3de opened this issue Sep 20, 2024 · 3 comments
Open

Allow configuring k6 runner blocked hostnames #901

ka3de opened this issue Sep 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ka3de
Copy link
Contributor

ka3de commented Sep 20, 2024

The internal k6 runner implementation in the agent hardcodes the --block-hostnames k6 option to *.cluster.local (here).
This should be configurable following a similar approach to the one implemented for --blacklist-ip.

Related #587.
@ka3de ka3de added the enhancement New feature or request label Sep 20, 2024
@peterschretlen peterschretlen mentioned this issue Sep 20, 2024
Open
@peterschretlen
Copy link
Contributor

Related: #735

@peterschretlen
Copy link
Contributor

Fix this together with #735

@nadiamoe
Copy link
Member

We can consider getting rid of this option completely. Security-wise, IP blocking should provide stronger guarantees than this does. Moreover, *.cluster.local is trivial to evade by just not typing it. foo.foo.svc (as opposed to foo.foo.svc.cluster.local.) is correctly resolved in the majority of kube-dns configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nadiamoe @ka3de @peterschretlen