-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove querier wait time metric. #11233
Changes from 1 commit
df98efe
0c750b8
9ceecbb
2aa2df2
ab87075
fb55650
bf96304
a232309
1b13901
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ func TestRecvFailDoesntCancelProcess(t *testing.T) { | |
running.Store(true) | ||
defer running.Store(false) | ||
|
||
mgr.processQueriesOnSingleStream(ctx, cc, "test:12345") | ||
mgr.processQueriesOnSingleStream(ctx, cc, "test:12345", "1") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right. Since it's ignored we don't need it here. |
||
}() | ||
|
||
test.Poll(t, time.Second, true, func() interface{} { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ package worker | |
|
||
import ( | ||
"context" | ||
"strconv" | ||
"sync" | ||
"time" | ||
|
||
|
@@ -64,7 +65,9 @@ func (pm *processorManager) concurrency(n int) { | |
n = 0 | ||
} | ||
|
||
workerId := 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i am guessing the workerId does not matter much here. but there is a chance here of re-using workerIds if the concurrency value changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good question. I wonder what happens then. Are we restarting the querier? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. when more schedulers get added? which means each worker gets a smaller concurrency value. |
||
for len(pm.cancels) < n { | ||
workerId++ | ||
ctx, cancel := context.WithCancel(pm.ctx) | ||
pm.cancels = append(pm.cancels, cancel) | ||
|
||
|
@@ -75,7 +78,7 @@ func (pm *processorManager) concurrency(n int) { | |
pm.currentProcessors.Inc() | ||
defer pm.currentProcessors.Dec() | ||
|
||
pm.p.processQueriesOnSingleStream(ctx, pm.conn, pm.address) | ||
pm.p.processQueriesOnSingleStream(ctx, pm.conn, pm.address, strconv.Itoa(workerId)) | ||
}() | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the
_
param intentional here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
processQueriesOnSingleStream
implements theprocessor
interface and we don't use the worker ID in the case of the frontend processor.